<p style="white-space: pre-wrap; word-wrap: break-word;">CR-1 due to a memleak.</p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h">File include/osmocom/bsc/neighbor_ident.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h@64">Patch Set #4, Line 64:</a> <code style="font-family:monospace,monospace">#include <osmocom/ctrl/control_cmd.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Let's rather add a forward declaration for 'struct ctrl_handle' above, rather than including a header in the middle of this file.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident.c">File src/osmo-bsc/neighbor_ident.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident.c@337">Patch Set #4, Line 337:</a> <code style="font-family:monospace,monospace">       return CTRL_CMD_REPLY;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So if we reach this part, we leak the 'tmp'? Let's finally make use of OTC_SELECT!</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident_vty.c">File src/osmo-bsc/neighbor_ident_vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident_vty.c@164">Patch Set #4, Line 164:</a> <code style="font-family:monospace,monospace"> cell_id = (struct gsm0808_cell_id){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This definition could be even shorter:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  static struct gsm0808_cell_id cell_id = {<br>    .id_discr = CELL_IDENT_WHOLE_GLOBAL_PS<br>  };</pre></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/osmo_bsc_main.c">File src/osmo-bsc/osmo_bsc_main.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/osmo_bsc_main.c@966">Patch Set #4, Line 966:</a> <code style="font-family:monospace,monospace">Failed to install neighbor control commands</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Something seems to be wrong here. "Failed to bind Neighbor Resolution Service"?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848">change 21848</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21848"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379 </div>
<div style="display:none"> Gerrit-Change-Number: 21848 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 08 Jan 2021 00:06:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>