<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22029">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bssgp_bvc_fsm: Handle block request from application correctly<br><br>This is no event from an incoming message so rx is NULL, and we can't send a<br>status PDU. Also blocking the signalling BVC is not allowed (unblocking it is already<br>forbidden).<br><br>Change-Id: I3e384b71d57e939efc1596ac1d92380ed5eb916d<br>Fixes: CID#215716<br>---<br>M src/gb/bssgp_bvc_fsm.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c</span><br><span>index cc634a5..6de0028 100644</span><br><span>--- a/src/gb/bssgp_bvc_fsm.c</span><br><span>+++ b/src/gb/bssgp_bvc_fsm.c</span><br><span>@@ -456,7 +456,10 @@</span><br><span>        case BSSGP_BVCFSM_E_REQ_BLOCK:</span><br><span>               if (bfp->role_sgsn) {</span><br><span>                     LOGPFSML(fi, LOGL_ERROR, "SGSN may not initiate BVC-BLOCK\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                        _tx_status(fi, BSSGP_CAUSE_SEM_INCORR_PDU, rx);</span><br><span style="color: hsl(120, 100%, 40%);">+                       break;</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span style="color: hsl(120, 100%, 40%);">+             if (bfp->bvci == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGPFSML(fi, LOGL_ERROR, "BVCI 0 cannot be blocked\n");</span><br><span>                    break;</span><br><span>               }</span><br><span>            bfp->locally_blocked = true;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22029">change 22029</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22029"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3e384b71d57e939efc1596ac1d92380ed5eb916d </div>
<div style="display:none"> Gerrit-Change-Number: 22029 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>