<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21970">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hodec2: cosmetic: add dBm unit to rxval logging<br><br>Change-Id: I58a5ae721b674576339360b1f03e91b015a1bf46<br>---<br>M src/osmo-bsc/handover_decision_2.c<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c</span><br><span>index 9fab1fc..477f1eb 100644</span><br><span>--- a/src/osmo-bsc/handover_decision_2.c</span><br><span>+++ b/src/osmo-bsc/handover_decision_2.c</span><br><span>@@ -829,18 +829,18 @@</span><br><span> </span><br><span>        if (candidate->cil)</span><br><span>               LOGPHOLCHANTOREMOTE(lchan, candidate->cil, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-                                   "RX level %d -> %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                   "RX level %d dBm -> %d dBm\n",</span><br><span>                                  rxlev2dbm(rxlev), rxlev2dbm(candidate->avg));</span><br><span> </span><br><span>     if (candidate->bts == lchan->ts->trx->bts)</span><br><span>               LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-               "RX level %d; "</span><br><span style="color: hsl(120, 100%, 40%);">+                     "RX level %d dBm; "</span><br><span>                HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) "\n",</span><br><span>                 rxlev2dbm(candidate->avg),</span><br><span>                HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));</span><br><span>      else if (candidate->bts)</span><br><span>          LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-               "RX level %d -> %d; "</span><br><span style="color: hsl(120, 100%, 40%);">+                    "RX level %d dBm -> %d dBm; "</span><br><span>                   HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) "\n",</span><br><span>                 rxlev2dbm(rxlev), rxlev2dbm(candidate->avg),</span><br><span>                      HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));</span><br><span>@@ -946,8 +946,8 @@</span><br><span>                unsigned int pwr_hyst = ho_get_hodec2_pwr_hysteresis(bts->ho);</span><br><span>            if (avg <= (av_rxlev + pwr_hyst)) {</span><br><span>                       LOGPHOCAND(&c, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-                             "Not a candidate, because RX level (%d) is lower"</span><br><span style="color: hsl(0, 100%, 40%);">-                             " or equal than current RX level (%d) + hysteresis (%d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                 "Not a candidate, because RX level (%d dBm) is lower"</span><br><span style="color: hsl(120, 100%, 40%);">+                               " or equal than current RX level (%d dBm) + hysteresis (%d)\n",</span><br><span>                                    rxlev2dbm(avg), rxlev2dbm(av_rxlev), pwr_hyst);</span><br><span>                   return;</span><br><span>              }</span><br><span>@@ -958,8 +958,8 @@</span><br><span>      min_rxlev = ho_get_hodec2_min_rxlev(neigh_cfg);</span><br><span>      if (rxlev2dbm(avg) < min_rxlev) {</span><br><span>                 LOGPHOCAND(&c, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-                     "Not a candidate, because RX level (%d) is lower"</span><br><span style="color: hsl(0, 100%, 40%);">-                     " than the minimum required RX level (%d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                       "Not a candidate, because RX level (%d dBm) is lower"</span><br><span style="color: hsl(120, 100%, 40%);">+                       " than the minimum required RX level (%d dBm)\n",</span><br><span>                          rxlev2dbm(avg), min_rxlev);</span><br><span>               return;</span><br><span>      }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21970">change 21970</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21970"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I58a5ae721b674576339360b1f03e91b015a1bf46 </div>
<div style="display:none"> Gerrit-Change-Number: 21970 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>