<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21946">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb_proxy_peer: sgsn can never be NULL in gbproxy_sgsn_by_nri()<br><br>Redundant check makes Coverity think that sgsn can be NULL...<br><br>Change-Id: Iffdeb18e0a5575a2a09129eed9b8a41c3340dcbf<br>Fixes: CID#215870<br>---<br>M src/gbproxy/gb_proxy_peer.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c</span><br><span>index 94f9c03..863bcce 100644</span><br><span>--- a/src/gbproxy/gb_proxy_peer.c</span><br><span>+++ b/src/gbproxy/gb_proxy_peer.c</span><br><span>@@ -482,7 +482,7 @@</span><br><span>        llist_for_each_entry(sgsn, &cfg->sgsns, list) {</span><br><span>               if (osmo_nri_v_matches_ranges(nri, sgsn->pool.nri_ranges)) {</span><br><span>                      /* Also check if the NRI we're looking for is a NULL NRI */</span><br><span style="color: hsl(0, 100%, 40%);">-                 if (sgsn && null_nri) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (null_nri) {</span><br><span>                              if (osmo_nri_v_matches_ranges(nri, cfg->pool.null_nri_ranges))</span><br><span>                                    *null_nri = true;</span><br><span>                            else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21946">change 21946</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21946"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iffdeb18e0a5575a2a09129eed9b8a41c3340dcbf </div>
<div style="display:none"> Gerrit-Change-Number: 21946 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>