<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21942">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sysinfo: fix less-than-zero comparison of an unsigned value<br><br>size_t is an unsigned type, while get_si4_ro_offset() returns int.<br><br>Change-Id: I3b216b70fbcc653ced734835ccb2c7f1932d9f0a<br>Fixes: CID#215888<br>---<br>M src/common/sysinfo.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/sysinfo.c b/src/common/sysinfo.c</span><br><span>index 9eea539..d1f6f36 100644</span><br><span>--- a/src/common/sysinfo.c</span><br><span>+++ b/src/common/sysinfo.c</span><br><span>@@ -240,8 +240,8 @@</span><br><span> void regenerate_si4_restoctets(struct gsm_bts *bts)</span><br><span> {</span><br><span>     uint8_t *si4_buf = GSM_BTS_SI(bts, SYSINFO_TYPE_4);</span><br><span style="color: hsl(0, 100%, 40%);">-     size_t si4_size;</span><br><span>     struct osmo_gsm48_si_ro_info si4ro_tmp;</span><br><span style="color: hsl(120, 100%, 40%);">+       int si4_size;</span><br><span> </span><br><span>    /* If BSC has never set SI4, there's nothing to patch */</span><br><span>         if (!GSM_BTS_HAS_SI(bts, SYSINFO_TYPE_4))</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21942">change 21942</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21942"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3b216b70fbcc653ced734835ccb2c7f1932d9f0a </div>
<div style="display:none"> Gerrit-Change-Number: 21942 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>