<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21980">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_test: include ack-chan in expect-chan<br><br>Change-Id: Ic9f1e94b12334fed6bdce35beef94d8e2968f3ad<br>---<br>M tests/handover/handover_test.c<br>M tests/handover/test_penalty_timer.ho_vty<br>2 files changed, 0 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/80/21980/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index 3c9b4ff..e3ccb64 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -971,11 +971,6 @@</span><br><span>                   gsm_lchan_name(lchan), gsm_lchan_name(chan_req_lchan));</span><br><span>               exit(1);</span><br><span>     }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void _ack_chan_activ(struct gsm_lchan *lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- fprintf(stderr, "- Acknowledging channel request on %s\n", gsm_lchan_name(lchan));</span><br><span>         got_ho_req = 0;</span><br><span>      send_chan_act_ack(lchan, 1);</span><br><span> }</span><br><span>@@ -1005,15 +1000,6 @@</span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN(ack_chan, ack_chan_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-      "ack-chan",</span><br><span style="color: hsl(0, 100%, 40%);">-      "ACK a previous Channel Request\n")</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-        OSMO_ASSERT(got_chan_req);</span><br><span style="color: hsl(0, 100%, 40%);">-      _ack_chan_activ(chan_req_lchan);</span><br><span style="color: hsl(0, 100%, 40%);">-        return CMD_SUCCESS;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> DEFUN(expect_ho_req, expect_ho_req_cmd,</span><br><span>       "expect-ho-req " LCHAN_ARGS,</span><br><span>       "Expect a handover of a given lchan\n"</span><br><span>@@ -1067,7 +1053,6 @@</span><br><span>    struct gsm_lchan *to = parse_lchan_args(argv+4);</span><br><span> </span><br><span>         _expect_chan_activ(to);</span><br><span style="color: hsl(0, 100%, 40%);">- _ack_chan_activ(to);</span><br><span>         _expect_ho_req(from);</span><br><span>        send_ho_detect(to);</span><br><span>  send_ho_complete(to, true);</span><br><span>@@ -1152,7 +1137,6 @@</span><br><span>  install_element(CONFIG_NODE, &congestion_check_cmd);</span><br><span>     install_element(CONFIG_NODE, &expect_no_chan_cmd);</span><br><span>       install_element(CONFIG_NODE, &expect_chan_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-     install_element(CONFIG_NODE, &ack_chan_cmd);</span><br><span>     install_element(CONFIG_NODE, &expect_ho_req_cmd);</span><br><span>        install_element(CONFIG_NODE, &ho_detection_cmd);</span><br><span>         install_element(CONFIG_NODE, &ho_complete_cmd);</span><br><span>diff --git a/tests/handover/test_penalty_timer.ho_vty b/tests/handover/test_penalty_timer.ho_vty</span><br><span>index be25c20..7b0d266 100644</span><br><span>--- a/tests/handover/test_penalty_timer.ho_vty</span><br><span>+++ b/tests/handover/test_penalty_timer.ho_vty</span><br><span>@@ -7,7 +7,6 @@</span><br><span> set-ts-use trx 0 0 states * TCH/F - - - - - -</span><br><span> meas-rep lchan 0 0 1 0 rxlev 20 rxqual 0 ta 0 neighbors 30</span><br><span> expect-chan lchan 1 0 1 0</span><br><span style="color: hsl(0, 100%, 40%);">-ack-chan</span><br><span> expect-ho-req lchan 0 0 1 0</span><br><span> ho-failed</span><br><span> expect-ts-use trx 0 0 states * TCH/F - - - - - -</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21980">change 21980</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21980"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic9f1e94b12334fed6bdce35beef94d8e2968f3ad </div>
<div style="display:none"> Gerrit-Change-Number: 21980 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>