<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21878">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  tnt: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">icE1usb fw: Don't store E1_*_CR_*_CLR in variables<br><br>Those clear bits are only set once at start-up and then later<br>explicitly.  They shouldn't be stored with the user configuration<br>in state variables.<br><br>Change-Id: If38e86aefea7f1be4e1ff5a88860f8be593eeedc<br>---<br>M firmware/ice40-riscv/icE1usb/e1.c<br>1 file changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>index 7682ce0..b1771f5 100644</span><br><span>--- a/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>+++ b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>@@ -248,17 +248,15 @@</span><br><span>     e1f_reset(&g_e1.tx.fifo, 128, 128);</span><br><span> </span><br><span>  /* Enable Rx */</span><br><span style="color: hsl(0, 100%, 40%);">- g_e1.rx.cr = E1_RX_CR_OVFL_CLR |</span><br><span style="color: hsl(0, 100%, 40%);">-                     E1_RX_CR_MODE_MFA |</span><br><span style="color: hsl(120, 100%, 40%);">+      g_e1.rx.cr = E1_RX_CR_MODE_MFA |</span><br><span>                  E1_RX_CR_ENABLE;</span><br><span style="color: hsl(0, 100%, 40%);">-   e1_regs->rx.csr = g_e1.rx.cr;</span><br><span style="color: hsl(120, 100%, 40%);">+      e1_regs->rx.csr = E1_RX_CR_OVFL_CLR | g_e1.rx.cr;</span><br><span> </span><br><span>     /* Enable Tx */</span><br><span style="color: hsl(0, 100%, 40%);">- g_e1.tx.cr = E1_TX_CR_UNFL_CLR |</span><br><span style="color: hsl(0, 100%, 40%);">-                     (clk_mode ? E1_TX_CR_TICK_REMOTE : E1_TX_CR_TICK_LOCAL) |</span><br><span style="color: hsl(120, 100%, 40%);">+        g_e1.tx.cr = (clk_mode ? E1_TX_CR_TICK_REMOTE : E1_TX_CR_TICK_LOCAL) |</span><br><span>                    E1_TX_CR_MODE_TS0_CRC_E |</span><br><span>                    E1_TX_CR_ENABLE;</span><br><span style="color: hsl(0, 100%, 40%);">-   e1_regs->tx.csr = g_e1.tx.cr;</span><br><span style="color: hsl(120, 100%, 40%);">+      e1_regs->tx.csr = E1_TX_CR_UNFL_CLR | g_e1.tx.cr;</span><br><span> </span><br><span>     /* State */</span><br><span>  g_e1.rx.state = BOOT;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21878">change 21878</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21878"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If38e86aefea7f1be4e1ff5a88860f8be593eeedc </div>
<div style="display:none"> Gerrit-Change-Number: 21878 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>