<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/21871">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sysmoISIM-SJA2: Add support for programming IPv4 address for PCSCF<br><br>This commit allows programming of IPv4 or FQDN in EF.PCSCF<br><br>Example:<br><br>./pySim-prog.py -p 0 -x 001 -y 01 -s 8988211900000000004 -i 001011234567895 -k 8baf473f2f8fd09487cccbd7097c6862 --op 11111111111111111111111111111111 -o 8E27B6AF0E692E750F32667A3B14605D -a 85524953 -n isim.test --msisdn 0598765432100 --epdgid 172.24.15.20 --pcscf 99.100.80.102 --ims-hdomain testims.org<br><br>Change-Id: I247a5413e9e5fef6b9d7b6cb8442313e72f9156a<br>---<br>M pySim/cards.py<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index b7be6e8..17da506 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -336,12 +336,16 @@</span><br><span> </span><br><span>    def update_pcscf(self, pcscf):</span><br><span>               if len(pcscf) > 0:</span><br><span style="color: hsl(0, 100%, 40%);">-                   content = enc_addr_tlv(pcscf)</span><br><span style="color: hsl(120, 100%, 40%);">+                 addr_type = get_addr_type(pcscf)</span><br><span style="color: hsl(120, 100%, 40%);">+                      if addr_type == None:</span><br><span style="color: hsl(120, 100%, 40%);">+                         raise ValueError("Unknown PCSCF address type or invalid address provided")</span><br><span style="color: hsl(120, 100%, 40%);">+                  content = enc_addr_tlv(pcscf, ('%02x' % addr_type))</span><br><span>          else:</span><br><span>                        # Just the tag value</span><br><span>                         content = '80'</span><br><span>               rec_size_bytes = self._scc.record_size(EF_ISIM_ADF_map['PCSCF'])</span><br><span style="color: hsl(0, 100%, 40%);">-                data, sw = self._scc.update_record(EF_ISIM_ADF_map['PCSCF'], 1, rpad(content, rec_size_bytes*2))</span><br><span style="color: hsl(120, 100%, 40%);">+              pcscf_tlv = rpad(content, rec_size_bytes*2)</span><br><span style="color: hsl(120, 100%, 40%);">+           data, sw = self._scc.update_record(EF_ISIM_ADF_map['PCSCF'], 1, pcscf_tlv)</span><br><span>           return sw</span><br><span> </span><br><span>        def read_domain(self):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/21871">change 21871</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/21871"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I247a5413e9e5fef6b9d7b6cb8442313e72f9156a </div>
<div style="display:none"> Gerrit-Change-Number: 21871 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>