<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/21956">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sysmoISIM-SJA2: Enable programming of EF.MSISDN<br><br>Change-Id: I8ed27142009a50a1cc31a9f2e0e854a53add6e89<br>---<br>M pySim/cards.py<br>M pysim-testdata/sysmoISIM-SJA2.ok<br>2 files changed, 12 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index ac6d223..a8dcf10 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -1287,6 +1287,17 @@</span><br><span>                  r = self._scc.select_file(['3f00', '7f10'])</span><br><span>                  data, sw = self._scc.update_record('6f42', 1, lpad(p['smsp'], 104), force_len=True)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+               # EF.MSISDN</span><br><span style="color: hsl(120, 100%, 40%);">+           # TODO: Alpha Identifier (currently 'ff'O * 20)</span><br><span style="color: hsl(120, 100%, 40%);">+               # TODO: Capability/Configuration1 Record Identifier</span><br><span style="color: hsl(120, 100%, 40%);">+           # TODO: Extension1 Record Identifier</span><br><span style="color: hsl(120, 100%, 40%);">+          if p.get('msisdn') is not None:</span><br><span style="color: hsl(120, 100%, 40%);">+                       msisdn = enc_msisdn(p['msisdn'])</span><br><span style="color: hsl(120, 100%, 40%);">+                      content = 'ff' * 20 + msisdn + 'ff' * 2</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                     r = self._scc.select_file(['3f00', '7f10'])</span><br><span style="color: hsl(120, 100%, 40%);">+                   data, sw = self._scc.update_record('6F40', 1, content, force_len=True)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>             # Populate AIDs</span><br><span>              self.read_aids()</span><br><span> </span><br><span>diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>index 26e20b0..b521c6d 100644</span><br><span>--- a/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>+++ b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>@@ -53,7 +53,7 @@</span><br><span>        ffffff0000 # unused</span><br><span> </span><br><span> ACC: 0200</span><br><span style="color: hsl(0, 100%, 40%);">-MSISDN: Not available</span><br><span style="color: hsl(120, 100%, 40%);">+MSISDN (NPI=1 ToN=3): 6766266</span><br><span> Administrative data: 00000002</span><br><span>    MS operation mode: normal operation</span><br><span>  Ciphering Indicator: disabled</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/21956">change 21956</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/21956"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8ed27142009a50a1cc31a9f2e0e854a53add6e89 </div>
<div style="display:none"> Gerrit-Change-Number: 21956 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>