<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/21952">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pySim-read.py: Enable reading of EF.IMPI from ISIM<br><br>IMS private user identity (IMPI)<br>As per TS1.103 version 14.2.0, this EF contains the private user identity of the user.<br>EF.IMPI consist of NAI TLV Data object.The NAI shall be encoded to an octet string<br>according to UTF-8 encoding rules as specified in IETF RFC 3629.<br><br>Reading of EF.IMPI is achieved by first selecting the ISIM application using its AID.<br>This is followed by selecting EF.IMPI with File ID - 6f02 in ADF.ISIM<br><br>Change-Id: I8d8e76e3f6b9ca7a0be262fee99cd5a397edbefa<br>---<br>M pySim-read.py<br>M pySim/cards.py<br>M pysim-testdata/sysmoISIM-SJA2.ok<br>3 files changed, 22 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index f63205a..a7d9063 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -315,6 +315,17 @@</span><br><span> except Exception as e:</span><br><span> print("Home Network Domain Name: Can't read file -- " + str(e))</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ # EF.IMPI - IMS private user identity</span><br><span style="color: hsl(120, 100%, 40%);">+ try:</span><br><span style="color: hsl(120, 100%, 40%);">+ if card.file_exists(EF_ISIM_ADF_map['IMPI']):</span><br><span style="color: hsl(120, 100%, 40%);">+ (res, sw) = card.read_impi()</span><br><span style="color: hsl(120, 100%, 40%);">+ if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+ print("IMS private user identity: %s" % (len(res) and res or 'Not available',))</span><br><span style="color: hsl(120, 100%, 40%);">+ else:</span><br><span style="color: hsl(120, 100%, 40%);">+ print("IMS private user identity: Can't read, response code = %s" % (sw,))</span><br><span style="color: hsl(120, 100%, 40%);">+ except Exception as e:</span><br><span style="color: hsl(120, 100%, 40%);">+ print("IMS private user identity: Can't read file -- " + str(e))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Check whether we have th AID of ISIM, if so select it by its AID</span><br><span> # EF.IST - File Id in ADF ISIM : 6f07</span><br><span> if '9000' == card.select_adf_by_aid(adf="isim"):</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 17da506..17b7bce 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -375,6 +375,16 @@</span><br><span> data, sw = self._scc.update_binary(EF_ISIM_ADF_map['DOMAIN'], rpad(content, bin_size_bytes*2))</span><br><span> return sw</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def read_impi(self):</span><br><span style="color: hsl(120, 100%, 40%);">+ (res, sw) = self._scc.read_binary(EF_ISIM_ADF_map['IMPI'])</span><br><span style="color: hsl(120, 100%, 40%);">+ if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+ # Skip the inital tag value ('80') byte and get length of contents</span><br><span style="color: hsl(120, 100%, 40%);">+ length = int(res[2:4], 16)</span><br><span style="color: hsl(120, 100%, 40%);">+ content = h2s(res[4:4+(length*2)])</span><br><span style="color: hsl(120, 100%, 40%);">+ return (content, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+ else:</span><br><span style="color: hsl(120, 100%, 40%);">+ return (None, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> class _MagicSimBase(Card):</span><br><span> """</span><br><span>diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>index 4cdd9d5..335c886 100644</span><br><span>--- a/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>+++ b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>@@ -183,6 +183,7 @@</span><br><span> Not available</span><br><span> </span><br><span> Home Network Domain Name: Not available</span><br><span style="color: hsl(120, 100%, 40%);">+IMS private user identity: Not available</span><br><span> ISIM Service Table: 190200</span><br><span> Service 1 - P-CSCF address</span><br><span> Service 4 - GBA-based Local Key Establishment Mechanism</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/21952">change 21952</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/21952"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8d8e76e3f6b9ca7a0be262fee99cd5a397edbefa </div>
<div style="display:none"> Gerrit-Change-Number: 21952 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>