<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/21955">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sysmoISIM-SJA2: Add support for programming IMS public user identity<br><br>This EF contains one or more records, with each record able<br>to hold a public SIP Identity (SIP URI) of the user. EF.IMPU consist of URI TLV data<br>object values see IETF RFC 3261. The URI shall be encoded to an octet string according<br>to UTF-8 encoding rules as specified in IETF RFC 3629<br><br>./pySim-prog.py -p 0 -x 001 -y 01 -s 8988211900000000004 -i 001011234567895 -k 8baf473f2f8fd09487cccbd7097c6862 --op 11111111111111111111111111111111 -o 8E27B6AF0E692E750F32667A3B14605D -a 85524953 -n isim.test --msisdn 0598765432100 --epdgid epdg.epc.mnc001.mcc001.pub.3gppnetwork.org --pcscf pcscf.ims.testop.org --ims-hdomain ims.testop.org --impi 1234567895@ims.testop.org --impu sip:5987654321@ims.testop.org<br><br>Change-Id: If10bc2e50eca390b81755b5cc7211e695233612d<br>---<br>M pySim-prog.py<br>M pySim/cards.py<br>2 files changed, 29 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-prog.py b/pySim-prog.py</span><br><span>index 3abd0bd..cf503d0 100755</span><br><span>--- a/pySim-prog.py</span><br><span>+++ b/pySim-prog.py</span><br><span>@@ -162,6 +162,9 @@</span><br><span> parser.add_option("--impi", dest="impi",</span><br><span> help="Set IMS private user identity",</span><br><span> )</span><br><span style="color: hsl(120, 100%, 40%);">+ parser.add_option("--impu", dest="impu",</span><br><span style="color: hsl(120, 100%, 40%);">+ help="Set IMS public user identity",</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span> parser.add_option("--read-imsi", dest="read_imsi", action="store_true",</span><br><span> help="Read the IMSI from the CARD", default=False</span><br><span> )</span><br><span>@@ -471,7 +474,8 @@</span><br><span> 'epdgSelection' : opts.epdgSelection,</span><br><span> 'pcscf' : opts.pcscf,</span><br><span> 'ims_hdomain': opts.ims_hdomain,</span><br><span style="color: hsl(0, 100%, 40%);">- 'impi' : opts.impi</span><br><span style="color: hsl(120, 100%, 40%);">+ 'impi' : opts.impi,</span><br><span style="color: hsl(120, 100%, 40%);">+ 'impu' : opts.impu,</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 62163a1..ac6d223 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -411,6 +411,19 @@</span><br><span> impu_recs += "IMS public user identity: Can't read, response code = %s\n" % (sw)</span><br><span> return impu_recs</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def update_impu(self, impu=None):</span><br><span style="color: hsl(120, 100%, 40%);">+ hex_str = ""</span><br><span style="color: hsl(120, 100%, 40%);">+ if impu:</span><br><span style="color: hsl(120, 100%, 40%);">+ hex_str = s2h(impu)</span><br><span style="color: hsl(120, 100%, 40%);">+ # Build TLV</span><br><span style="color: hsl(120, 100%, 40%);">+ tlv = TLV(['80'])</span><br><span style="color: hsl(120, 100%, 40%);">+ content = tlv.build({'80': hex_str})</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rec_size_bytes = self._scc.record_size(EF_ISIM_ADF_map['IMPU'])</span><br><span style="color: hsl(120, 100%, 40%);">+ impu_tlv = rpad(content, rec_size_bytes*2)</span><br><span style="color: hsl(120, 100%, 40%);">+ data, sw = self._scc.update_record(EF_ISIM_ADF_map['IMPU'], 1, impu_tlv)</span><br><span style="color: hsl(120, 100%, 40%);">+ return sw</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> class _MagicSimBase(Card):</span><br><span> """</span><br><span>@@ -1323,6 +1336,17 @@</span><br><span> if sw != '9000':</span><br><span> print("Programming IMPI failed with code %s"%sw)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ # update EF.IMPU in ADF.ISIM</span><br><span style="color: hsl(120, 100%, 40%);">+ # TODO: Validate IMPU input</span><br><span style="color: hsl(120, 100%, 40%);">+ # Support multiple IMPU if there is enough space</span><br><span style="color: hsl(120, 100%, 40%);">+ if self.file_exists(EF_ISIM_ADF_map['IMPU']):</span><br><span style="color: hsl(120, 100%, 40%);">+ if p.get('impu'):</span><br><span style="color: hsl(120, 100%, 40%);">+ sw = self.update_impu(p['impu'])</span><br><span style="color: hsl(120, 100%, 40%);">+ else:</span><br><span style="color: hsl(120, 100%, 40%);">+ sw = self.update_impu()</span><br><span style="color: hsl(120, 100%, 40%);">+ if sw != '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+ print("Programming IMPU failed with code %s"%sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if '9000' == self.select_adf_by_aid():</span><br><span> # update EF-USIM_AUTH_KEY in ADF.USIM</span><br><span> if p.get('ki'):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/21955">change 21955</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/21955"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If10bc2e50eca390b81755b5cc7211e695233612d </div>
<div style="display:none"> Gerrit-Change-Number: 21955 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>