<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21948">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp: fix uninitialized struct fields in bssgp_create_rim_ri()<br><br>Change-Id: Ifc3dda1fe5e9743072751dbb14c2d973388cb3b2<br>Fixes: CID#215836<br>---<br>M src/gb/gprs_bssgp.c<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/21948/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index fd2a48c..bf0e821 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -398,9 +398,12 @@</span><br><span>                /* Note: 3GPP TS 24.301 Figure 9.9.3.32.1 and 3GPP TS 24.008</span><br><span>                  * Figure 10.5.130 specify MCC/MNC encoding in the same way,</span><br><span>                  * so we can re-use gsm48_encode_ra() for that. */</span><br><span style="color: hsl(0, 100%, 40%);">-              raid_temp.mcc = ri->eutran.tai.mcc;</span><br><span style="color: hsl(0, 100%, 40%);">-          raid_temp.mnc = ri->eutran.tai.mnc;</span><br><span style="color: hsl(0, 100%, 40%);">-          raid_temp.mnc_3_digits = ri->eutran.tai.mnc_3_digits;</span><br><span style="color: hsl(120, 100%, 40%);">+              raid_temp = (struct gprs_ra_id) {</span><br><span style="color: hsl(120, 100%, 40%);">+                     .mcc = ri->eutran.tai.mcc,</span><br><span style="color: hsl(120, 100%, 40%);">+                 .mnc = ri->eutran.tai.mnc,</span><br><span style="color: hsl(120, 100%, 40%);">+                 .mnc_3_digits = ri->eutran.tai.mnc_3_digits,</span><br><span style="color: hsl(120, 100%, 40%);">+               };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                 gsm48_encode_ra((struct gsm48_ra_id *)buf, &raid_temp);</span><br><span>          osmo_store16be(ri->eutran.tai.tac, buf + 3);</span><br><span>              OSMO_ASSERT(ri->eutran.global_enb_id_len <=</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21948">change 21948</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21948"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifc3dda1fe5e9743072751dbb14c2d973388cb3b2 </div>
<div style="display:none"> Gerrit-Change-Number: 21948 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>