<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/21866">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sysmoISIM-SJA2: Add support for programming IMS Home Network Domain Name<br><br>As per 3GPP TS 31.103, this EF (DOMAIN) can found under ADF.ISIM at File Id 6f03.<br><br>The Home Network Domain Name, i.e. FQDN shall be encoded to an octet string<br>according to UTF-8 encoding rules as specified in IETF RFC 3629 [27].<br>The tag value of the Home Network Domain Name TLV data object shall be '80'.<br><br>Example:<br><br>./pySim-prog.py -p 0 -x 001 -y 01 -s 8988211900000000004 -i 001011234567895 -k 8baf473f2f8fd09487cccbd7097c6862 --op 11111111111111111111111111111111 -o 8E27B6AF0E692E750F32667A3B14605D -a 85524953 -n isim.test --msisdn 0598765432100 --epdgid epdg.epc.mnc001.mcc001.pub.3gppnetwork.org --pcscf pcscf.testims.org --ims-hdomain testims.org<br><br>Change-Id: I3c823203aee88734ae423e4ad73da1027a4eaeed<br>---<br>M pySim-prog.py<br>M pySim/cards.py<br>2 files changed, 32 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-prog.py b/pySim-prog.py</span><br><span>index 7ad57e6..f278015 100755</span><br><span>--- a/pySim-prog.py</span><br><span>+++ b/pySim-prog.py</span><br><span>@@ -156,6 +156,9 @@</span><br><span> parser.add_option("--pcscf", dest="pcscf",</span><br><span> help="Set Proxy Call Session Control Function (P-CSCF) Address. (Only FQDN format supported)",</span><br><span> )</span><br><span style="color: hsl(120, 100%, 40%);">+ parser.add_option("--ims-hdomain", dest="ims_hdomain",</span><br><span style="color: hsl(120, 100%, 40%);">+ help="Set IMS Home Network Domain Name in FQDN format",</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span> parser.add_option("--read-imsi", dest="read_imsi", action="store_true",</span><br><span> help="Read the IMSI from the CARD", default=False</span><br><span> )</span><br><span>@@ -464,6 +467,7 @@</span><br><span> 'epdgid' : opts.epdgid,</span><br><span> 'epdgSelection' : opts.epdgSelection,</span><br><span> 'pcscf' : opts.pcscf,</span><br><span style="color: hsl(120, 100%, 40%);">+ 'ims_hdomain': opts.ims_hdomain,</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 42460fe..7e47916 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -28,6 +28,7 @@</span><br><span> from pySim.ts_31_103 import EF_ISIM_ADF_map</span><br><span> from pySim.utils import *</span><br><span> from smartcard.util import toBytes</span><br><span style="color: hsl(120, 100%, 40%);">+from pytlv.TLV import *</span><br><span> </span><br><span> class Card(object):</span><br><span> </span><br><span>@@ -346,6 +347,23 @@</span><br><span> else:</span><br><span> return (None, sw)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def update_domain(self, domain=None, mcc=None, mnc=None):</span><br><span style="color: hsl(120, 100%, 40%);">+ hex_str = ""</span><br><span style="color: hsl(120, 100%, 40%);">+ if domain:</span><br><span style="color: hsl(120, 100%, 40%);">+ hex_str = s2h(domain)</span><br><span style="color: hsl(120, 100%, 40%);">+ elif mcc and mnc:</span><br><span style="color: hsl(120, 100%, 40%);">+ # MCC and MNC always has 3 digits in domain form</span><br><span style="color: hsl(120, 100%, 40%);">+ plmn_str = 'mnc' + lpad(mnc, 3, "0") + '.mcc' + lpad(mcc, 3, "0")</span><br><span style="color: hsl(120, 100%, 40%);">+ hex_str = s2h('ims.' + plmn_str + '.3gppnetwork.org')</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # Build TLV</span><br><span style="color: hsl(120, 100%, 40%);">+ tlv = TLV(['80'])</span><br><span style="color: hsl(120, 100%, 40%);">+ content = tlv.build({'80': hex_str})</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bin_size_bytes = self._scc.binary_size(EF_ISIM_ADF_map['DOMAIN'])</span><br><span style="color: hsl(120, 100%, 40%);">+ data, sw = self._scc.update_binary(EF_ISIM_ADF_map['DOMAIN'], rpad(content, bin_size_bytes*2))</span><br><span style="color: hsl(120, 100%, 40%);">+ return sw</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> class _MagicSimBase(Card):</span><br><span> """</span><br><span>@@ -1238,6 +1256,16 @@</span><br><span> print("Programming P-CSCF failed with code %s"%sw)</span><br><span> </span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ # update EF.DOMAIN in ADF.ISIM</span><br><span style="color: hsl(120, 100%, 40%);">+ if self.file_exists(EF_ISIM_ADF_map['DOMAIN']):</span><br><span style="color: hsl(120, 100%, 40%);">+ if p.get('ims_hdomain'):</span><br><span style="color: hsl(120, 100%, 40%);">+ sw = self.update_domain(domain=p['ims_hdomain'])</span><br><span style="color: hsl(120, 100%, 40%);">+ else:</span><br><span style="color: hsl(120, 100%, 40%);">+ sw = self.update_domain()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if sw != '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+ print("Programming Home Network Domain Name failed with code %s"%sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if '9000' == self.select_adf_by_aid():</span><br><span> # update EF-USIM_AUTH_KEY in ADF.USIM</span><br><span> if p.get('ki'):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/21866">change 21866</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/21866"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3c823203aee88734ae423e4ad73da1027a4eaeed </div>
<div style="display:none"> Gerrit-Change-Number: 21866 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>