<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21928">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_Tests: fix unreachable code after f_shutdown_helper()<br><br>This function does 'mtc.stop', so it must be always called last.<br><br>Change-Id: If2c991d6ac23e43aafd32814ca17cf2093cb1522<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index fe50e06..f72ab22 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -3681,9 +3681,9 @@</span><br><span> </span><br><span>  vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);</span><br><span>     vc_conn.done;</span><br><span style="color: hsl(0, 100%, 40%);">-   f_shutdown_helper();</span><br><span> </span><br><span>     f_vty_amr_start_mode_restore(true);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span> testcase TC_assignment_codec_amr_h() runs on test_CT {</span><br><span>@@ -3709,9 +3709,9 @@</span><br><span> </span><br><span>  vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);</span><br><span>     vc_conn.done;</span><br><span style="color: hsl(0, 100%, 40%);">-   f_shutdown_helper();</span><br><span> </span><br><span>     f_vty_amr_start_mode_restore(false);</span><br><span style="color: hsl(120, 100%, 40%);">+  f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span> /* 'amr start-mode auto' should not keep the (unused) 'smod' bits from previous configuration */</span><br><span>@@ -3743,11 +3743,11 @@</span><br><span> </span><br><span>      vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);</span><br><span>     vc_conn.done;</span><br><span style="color: hsl(0, 100%, 40%);">-   f_shutdown_helper();</span><br><span> </span><br><span>     /* Clear the startmode bits to not affect subsequent tests, in case the bits should indeed stick around. */</span><br><span>  f_vty_amr_start_mode_set(true, "1");</span><br><span>       f_vty_amr_start_mode_restore(true);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span> function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring s8_s0, bitstring exp_s8_s0,</span><br><span>@@ -4257,9 +4257,9 @@</span><br><span> </span><br><span>        vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);</span><br><span>     vc_conn.done;</span><br><span style="color: hsl(0, 100%, 40%);">-   f_shutdown_helper();</span><br><span> </span><br><span>     f_vty_amr_start_mode_restore(false);</span><br><span style="color: hsl(120, 100%, 40%);">+  f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span> /* test the procedure of the MSC requesting a Classmark Update:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21928">change 21928</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21928"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If2c991d6ac23e43aafd32814ca17cf2093cb1522 </div>
<div style="display:none"> Gerrit-Change-Number: 21928 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>