<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21908">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rsl: remove redundant boolean flag in rsl_rx_chan_activ()<br><br>Checking if a given RSL IE is present is a straightforward task,<br>so there is no need for a special boolean flag.<br><br>Change-Id: I6a12930314c79b9c3efabfa575b17f78105fea4c<br>---<br>M src/common/rsl.c<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index f7f336a..ef23039 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1124,7 +1124,6 @@</span><br><span> struct tlv_parsed tp;</span><br><span> uint8_t type;</span><br><span> int rc;</span><br><span style="color: hsl(0, 100%, 40%);">- bool ms_power_present = false;</span><br><span> </span><br><span> if (lchan->state != LCHAN_S_NONE) {</span><br><span> LOGPLCHAN(lchan, DRSL, LOGL_ERROR, "error: lchan is not available, but in state: %s.\n",</span><br><span>@@ -1229,7 +1228,6 @@</span><br><span> if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)) {</span><br><span> lchan->ms_power_ctrl.max = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F;</span><br><span> lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;</span><br><span style="color: hsl(0, 100%, 40%);">- ms_power_present = true;</span><br><span> }</span><br><span> /* 9.3.24 Timing Advance */</span><br><span> if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1))</span><br><span>@@ -1366,7 +1364,7 @@</span><br><span> switch (type) {</span><br><span> case RSL_ACT_INTER_ASYNC:</span><br><span> case RSL_ACT_INTER_SYNC:</span><br><span style="color: hsl(0, 100%, 40%);">- lchan->want_dl_sacch_active = ms_power_present;</span><br><span style="color: hsl(120, 100%, 40%);">+ lchan->want_dl_sacch_active = TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1);</span><br><span> break;</span><br><span> default:</span><br><span> lchan->want_dl_sacch_active = true;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21908">change 21908</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21908"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6a12930314c79b9c3efabfa575b17f78105fea4c </div>
<div style="display:none"> Gerrit-Change-Number: 21908 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>