<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c">File firmware/ice40-riscv/icE1usb/e1.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c@277">Patch Set #3, Line 277:</a> <code style="font-family:monospace,monospace">      e1_regs->tx.csr = (e1_regs->tx.csr & ~TXCR_PERMITTED) | g_e1.tx.cr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No that's not correct, the overflow bit (read only) is the same as the overflow clear (write only) for instance so this would clear all overflow ...</p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be :</p><p style="white-space: pre-wrap; word-wrap: break-word;">g_e1.tx.cr = (g_e1.tx.cr & ~TX_CRPERMITED) & (cr & TXCR_PERMITTED);<br>e1_regs->tx.csr = g_e1.tx.cr;</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c@288">Patch Set #3, Line 288:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same as TX</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774">change 21774</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib23f9b99f169ab18d730bcf67b97a7b6bf863e98 </div>
<div style="display:none"> Gerrit-Change-Number: 21774 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 30 Dec 2020 12:55:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>