<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21909">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: fix NULL-pointer dereference in cfg_bts_rep_dl_facch()<br><br>There is only one parameter in command:<br><br>  repeat dl-facch (command|all)<br><br>so indeed argv[0] must be used instead of argv[1].<br><br>Change-Id: I01efff109a33791e13b0149fc47c792d3266da71<br>Related: SYS#5114<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/21909/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 5692646..f4d2b82 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -2760,7 +2760,7 @@</span><br><span>             return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (!strcmp(argv[1], "command")) {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!strcmp(argv[0], "command")) {</span><br><span>                 bts->repeated_acch_policy.dl_facch_cmd = true;</span><br><span>            bts->repeated_acch_policy.dl_facch_all = false;</span><br><span>   } else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21909">change 21909</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I01efff109a33791e13b0149fc47c792d3266da71 </div>
<div style="display:none"> Gerrit-Change-Number: 21909 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>