<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21912">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: fix wrong attributes for UL/DL ACCH repeation commands<br><br>None of those commands apply immediately, they only affect newly<br>established logical channels.  The reason is that the related<br>IEs are only getting sent on channel activation / assignment.<br><br>Change-Id: I06c7851115fb31d1eb92c400d9724f4f051bd171<br>Related: SYS#5114<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 41 insertions(+), 38 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/21912/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 883b4fc..dcae631 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -2744,13 +2744,14 @@</span><br><span> </span><br><span> #define REP_ACCH_STR "FACCH/SACCH repetition\n"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_bts_rep_dl_facch,</span><br><span style="color: hsl(0, 100%, 40%);">-          cfg_bts_rep_dl_facch_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-       "repeat dl-facch (command|all)",</span><br><span style="color: hsl(0, 100%, 40%);">-      REP_ACCH_STR</span><br><span style="color: hsl(0, 100%, 40%);">-    "Enable DL-FACCH repetition for this BTS\n"</span><br><span style="color: hsl(0, 100%, 40%);">-           "command LAPDm frames only\n"</span><br><span style="color: hsl(0, 100%, 40%);">-         "all LAPDm frames\n", CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_bts_rep_dl_facch,</span><br><span style="color: hsl(120, 100%, 40%);">+         cfg_bts_rep_dl_facch_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+             X(BSC_VTY_ATTR_NEW_LCHAN),</span><br><span style="color: hsl(120, 100%, 40%);">+            "repeat dl-facch (command|all)",</span><br><span style="color: hsl(120, 100%, 40%);">+            REP_ACCH_STR</span><br><span style="color: hsl(120, 100%, 40%);">+          "Enable DL-FACCH repetition for this BTS\n"</span><br><span style="color: hsl(120, 100%, 40%);">+         "command LAPDm frames only\n"</span><br><span style="color: hsl(120, 100%, 40%);">+       "all LAPDm frames\n")</span><br><span> {</span><br><span>   struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2770,11 +2771,12 @@</span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_bts_rep_no_dl_facch,</span><br><span style="color: hsl(0, 100%, 40%);">-    cfg_bts_rep_no_dl_facch_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-    "no repeat dl-facch",</span><br><span style="color: hsl(0, 100%, 40%);">-         NO_STR REP_ACCH_STR</span><br><span style="color: hsl(0, 100%, 40%);">-     "Disable DL-FACCH repetition for this BTS\n", CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_bts_rep_no_dl_facch,</span><br><span style="color: hsl(120, 100%, 40%);">+              cfg_bts_rep_no_dl_facch_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+          X(BSC_VTY_ATTR_NEW_LCHAN),</span><br><span style="color: hsl(120, 100%, 40%);">+            "no repeat dl-facch",</span><br><span style="color: hsl(120, 100%, 40%);">+       NO_STR REP_ACCH_STR</span><br><span style="color: hsl(120, 100%, 40%);">+           "Disable DL-FACCH repetition for this BTS\n")</span><br><span> {</span><br><span>   struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2784,13 +2786,13 @@</span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_bts_rep_ul_dl_sacch,</span><br><span style="color: hsl(0, 100%, 40%);">-    cfg_bts_rep_ul_dl_sacch_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-    "repeat (ul-sacch|dl-sacch)",</span><br><span style="color: hsl(0, 100%, 40%);">-         REP_ACCH_STR</span><br><span style="color: hsl(0, 100%, 40%);">-    "Enable UL-SACCH repetition for this BTS\n"</span><br><span style="color: hsl(0, 100%, 40%);">-           "Enable DL-SACCH repetition for this BTS\n",</span><br><span style="color: hsl(0, 100%, 40%);">-          CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_bts_rep_ul_dl_sacch,</span><br><span style="color: hsl(120, 100%, 40%);">+              cfg_bts_rep_ul_dl_sacch_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+          X(BSC_VTY_ATTR_NEW_LCHAN),</span><br><span style="color: hsl(120, 100%, 40%);">+            "repeat (ul-sacch|dl-sacch)",</span><br><span style="color: hsl(120, 100%, 40%);">+       REP_ACCH_STR</span><br><span style="color: hsl(120, 100%, 40%);">+          "Enable UL-SACCH repetition for this BTS\n"</span><br><span style="color: hsl(120, 100%, 40%);">+         "Enable DL-SACCH repetition for this BTS\n")</span><br><span> {</span><br><span>    struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2808,11 +2810,12 @@</span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_bts_rep_no_ul_dl_sacch,</span><br><span style="color: hsl(0, 100%, 40%);">-         cfg_bts_rep_no_ul_dl_sacch_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-         "no repeat (ul-sacch|dl-sacch)",</span><br><span style="color: hsl(0, 100%, 40%);">-      NO_STR REP_ACCH_STR</span><br><span style="color: hsl(0, 100%, 40%);">-     "Disable DL-SACCH repetition for this BTS\n", CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_bts_rep_no_ul_dl_sacch,</span><br><span style="color: hsl(120, 100%, 40%);">+           cfg_bts_rep_no_ul_dl_sacch_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+       X(BSC_VTY_ATTR_NEW_LCHAN),</span><br><span style="color: hsl(120, 100%, 40%);">+            "no repeat (ul-sacch|dl-sacch)",</span><br><span style="color: hsl(120, 100%, 40%);">+            NO_STR REP_ACCH_STR</span><br><span style="color: hsl(120, 100%, 40%);">+           "Disable DL-SACCH repetition for this BTS\n")</span><br><span> {</span><br><span>   struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2824,20 +2827,20 @@</span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN_ATTR(cfg_bts_rep_rxqual,</span><br><span style="color: hsl(0, 100%, 40%);">-         cfg_bts_rep_rxqual_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-         "repeat rxqual (0|1|2|3|4|5|6|7)",</span><br><span style="color: hsl(0, 100%, 40%);">-    REP_ACCH_STR</span><br><span style="color: hsl(0, 100%, 40%);">-    "Set UL-SACCH/DL-FACCH rxqual threshold-ber\n"</span><br><span style="color: hsl(0, 100%, 40%);">-        "0 disabled (always on)\n"</span><br><span style="color: hsl(0, 100%, 40%);">-    "1 0.26% to 0.30% BER\n"</span><br><span style="color: hsl(0, 100%, 40%);">-      "2 0.51% to 0.64% BER\n"</span><br><span style="color: hsl(0, 100%, 40%);">-      "3 1.0% to 1.3% BER\n"</span><br><span style="color: hsl(0, 100%, 40%);">-        "4 1.9% to 2.7% BER (default)\n"</span><br><span style="color: hsl(0, 100%, 40%);">-      "5 3.8% to 5.4% BER\n"</span><br><span style="color: hsl(0, 100%, 40%);">-        "6 7.6% to 11.0% BER\n"</span><br><span style="color: hsl(0, 100%, 40%);">-       "7 Greater than 15.0% BER\n",</span><br><span style="color: hsl(0, 100%, 40%);">-         CMD_ATTR_IMMEDIATE)</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_USRATTR(cfg_bts_rep_rxqual,</span><br><span style="color: hsl(120, 100%, 40%);">+           cfg_bts_rep_rxqual_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+       X(BSC_VTY_ATTR_NEW_LCHAN),</span><br><span style="color: hsl(120, 100%, 40%);">+            "repeat rxqual (0|1|2|3|4|5|6|7)",</span><br><span style="color: hsl(120, 100%, 40%);">+          REP_ACCH_STR</span><br><span style="color: hsl(120, 100%, 40%);">+          "Set UL-SACCH/DL-FACCH rxqual threshold-ber\n"</span><br><span style="color: hsl(120, 100%, 40%);">+              "0 disabled (always on)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+          "1 0.26% to 0.30% BER\n"</span><br><span style="color: hsl(120, 100%, 40%);">+            "2 0.51% to 0.64% BER\n"</span><br><span style="color: hsl(120, 100%, 40%);">+            "3 1.0% to 1.3% BER\n"</span><br><span style="color: hsl(120, 100%, 40%);">+              "4 1.9% to 2.7% BER (default)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+            "5 3.8% to 5.4% BER\n"</span><br><span style="color: hsl(120, 100%, 40%);">+              "6 7.6% to 11.0% BER\n"</span><br><span style="color: hsl(120, 100%, 40%);">+             "7 Greater than 15.0% BER\n")</span><br><span> {</span><br><span>   struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21912">change 21912</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21912"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I06c7851115fb31d1eb92c400d9724f4f051bd171 </div>
<div style="display:none"> Gerrit-Change-Number: 21912 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>