<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21888">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Add comments to sgsn functions<br><br>Change-Id: I8c96308045112f25292b0e57c306d8486a2524cc<br>---<br>M src/gbproxy/gb_proxy_main.c<br>M src/gbproxy/gb_proxy_peer.c<br>2 files changed, 24 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy_main.c b/src/gbproxy/gb_proxy_main.c</span><br><span>index e85e951..c660ede 100644</span><br><span>--- a/src/gbproxy/gb_proxy_main.c</span><br><span>+++ b/src/gbproxy/gb_proxy_main.c</span><br><span>@@ -303,6 +303,8 @@</span><br><span> </span><br><span> gprs_ns2_vty_create();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: Warn if we create a gbproxy_nse for an NSEI which we don't have a bind */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* start telnet after reading config for vty_get_bind_addr() */</span><br><span> rc = telnet_init_dynif(tall_sgsn_ctx, NULL,</span><br><span> vty_get_bind_addr(), OSMO_VTY_PORT_GBPROXY);</span><br><span>diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c</span><br><span>index 595e2a6..a966c6c 100644</span><br><span>--- a/src/gbproxy/gb_proxy_peer.c</span><br><span>+++ b/src/gbproxy/gb_proxy_peer.c</span><br><span>@@ -343,7 +343,15 @@</span><br><span> return nse;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* SGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+/***********************************************************************</span><br><span style="color: hsl(120, 100%, 40%);">+ * SGSN - Serving GPRS Support Node</span><br><span style="color: hsl(120, 100%, 40%);">+ ***********************************************************************/</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Allocate a new SGSN. This ensures the corresponding gbproxy_nse is allocated as well</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] cfg The gbproxy configuration</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] nsei The nsei where the SGSN can be reached</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return The SGSN, NULL if it couldn't be allocated</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> struct gbproxy_sgsn *gbproxy_sgsn_alloc(struct gbproxy_config *cfg, uint16_t nsei)</span><br><span> {</span><br><span> struct gbproxy_sgsn *sgsn;</span><br><span>@@ -381,6 +389,9 @@</span><br><span> talloc_free(sgsn);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! Free the SGSN. This ensures the corresponding gbproxy_nse is freed as well</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] sgsn The SGSN</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> void gbproxy_sgsn_free(struct gbproxy_sgsn *sgsn)</span><br><span> {</span><br><span> if (!sgsn)</span><br><span>@@ -392,6 +403,11 @@</span><br><span> _sgsn_free(sgsn);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! Return the SGSN for a given NSEI</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] cfg The gbproxy configuration</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] nsei The nsei where the SGSN can be reached</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return Returns the matching SGSN or NULL if it couldn't be found</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> struct gbproxy_sgsn *gbproxy_sgsn_by_nsei(struct gbproxy_config *cfg, uint16_t nsei)</span><br><span> {</span><br><span> struct gbproxy_sgsn *sgsn;</span><br><span>@@ -405,6 +421,11 @@</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! Return the SGSN for a given NSEI, creating a new one if none exists</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] cfg The gbproxy configuration</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] nsei The nsei where the SGSN can be reached</span><br><span style="color: hsl(120, 100%, 40%);">+ * \return Returns the SGSN</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> struct gbproxy_sgsn *gbproxy_sgsn_by_nsei_or_new(struct gbproxy_config *cfg, uint16_t nsei)</span><br><span> {</span><br><span> struct gbproxy_sgsn *sgsn;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21888">change 21888</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21888"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8c96308045112f25292b0e57c306d8486a2524cc </div>
<div style="display:none"> Gerrit-Change-Number: 21888 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>