<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21782">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
tnt: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add support for icE1usb interrupt endpoint error reporting<br><br>Related: OS#4674<br>Change-Id: I5b0bf3cf40c623c17f2e88292e880b545c36b7b6<br>Depends: osmo-e1-hardware If157fde9d4ca05910b09537e19f37603c6d925f0<br>---<br>M src/Makefile.am<br>A src/ice1usb_proto.h<br>M src/usb.c<br>3 files changed, 196 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/Makefile.am b/src/Makefile.am</span><br><span>index 6dd13ce..d9d8236 100644</span><br><span>--- a/src/Makefile.am</span><br><span>+++ b/src/Makefile.am</span><br><span>@@ -21,6 +21,7 @@</span><br><span> </span><br><span> noinst_HEADERS = \</span><br><span> e1d.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ ice1usb_proto.h \</span><br><span> log.h \</span><br><span> $(NULL)</span><br><span> </span><br><span>diff --git a/src/ice1usb_proto.h b/src/ice1usb_proto.h</span><br><span>new file mode 100644</span><br><span>index 0000000..5f5f31c</span><br><span>--- /dev/null</span><br><span>+++ b/src/ice1usb_proto.h</span><br><span>@@ -0,0 +1,99 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Header file describing the USB protocol between the icE1usb firmware and the host</span><br><span style="color: hsl(120, 100%, 40%);">+ * software (currently really only osmo-e1d) */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/***********************************************************************</span><br><span style="color: hsl(120, 100%, 40%);">+ * Control Endpoint / Device Requests</span><br><span style="color: hsl(120, 100%, 40%);">+ ***********************************************************************/</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! returns a bit-mask of optional device capabilities (see enum e1usb_dev_capability) */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_DEV_GET_CAPABILITIES 0x01</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_DEV_GET_FW_BUILD 0x02</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum e1usb_dev_capability {</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! Does this board have a GPS-DO */</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_DEV_CAP_GPSDO,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Interface Requests */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! returns a bit-mask of optional device capabilities (see enum e1usb_intf_capability) */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_INTF_GET_CAPABILITIES 0x01</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_INTF_SET_TX_CFG 0x02 /*!< struct ice1usb_tx_config */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_INTF_GET_TX_CFG 0x03 /*!< struct ice1usb_tx_config */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_INTF_SET_RX_CFG 0x04 /*!< struct ice1usb_rx_config */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_INTF_GET_RX_CFG 0x05 /*!< struct ice1usb_rx_config */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+//enum e1usb_intf_capability { };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum ice1usb_tx_mode {</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_MODE_TRANSP = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_MODE_TS0 = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_MODE_TS0_CRC4 = 2,</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_MODE_TS0_CRC4_E = 3,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum ice1usb_tx_timing {</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_TIME_SRC_LOCAL = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_TIME_SRC_REMOTE = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum ice1usb_tx_ext_loopback {</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_EXT_LOOPBACK_OFF = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_EXT_LOOPBACK_SAME = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_TX_EXT_LOOPBACK_CROSS = 2,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* ICE1USB_INTF_{GET,SET}_TX_CFG */</span><br><span style="color: hsl(120, 100%, 40%);">+struct ice1usb_tx_config {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t mode; /*!< enum ice1usb_tx_mode */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t timing; /*!< enum ice1usb_tx_timing */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t ext_loopback; /*!< enum ice1usb_tx_ext_loopback */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t alarm; /*!< 1 = transmit alarm; 0 = don't */</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum ice1usb_rx_mode {</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! transparent, unaligned bitstream */</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_RX_MODE_TRANSP = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! alignment to E1 frame */</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_RX_MODE_FRAME = 2,</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! alignment to E1 multiframe */</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_RX_MODE_MULTIFRAME = 3,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* ICE1USB_INTF_{GET,SET}_RX_CFG */</span><br><span style="color: hsl(120, 100%, 40%);">+struct ice1usb_rx_config {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t mode; /*!< enum ice1usb_rx_mode */</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/***********************************************************************</span><br><span style="color: hsl(120, 100%, 40%);">+ * Interrupt Endpoint</span><br><span style="color: hsl(120, 100%, 40%);">+ ***********************************************************************/</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum ice1usb_irq_type {</span><br><span style="color: hsl(120, 100%, 40%);">+ ICE1USB_IRQQ_T_ERRCNT = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Ensue ro keep those in sync with e1.h */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_ERR_F_ALIGN_ERR 0x01</span><br><span style="color: hsl(120, 100%, 40%);">+#define ICE1USB_ERR_F_TICK_ERR 0x02</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct ice1usb_irq_err {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 16-bit little-endian counters */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t crc;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t align;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t ovfl;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t unfl;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t flags;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct ice1usb_irq {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t type; /*!< enum ice1usb_irq_type */</span><br><span style="color: hsl(120, 100%, 40%);">+ union {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ice1usb_irq_err errors;</span><br><span style="color: hsl(120, 100%, 40%);">+ } u;</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span>diff --git a/src/usb.c b/src/usb.c</span><br><span>index be4de44..35d47ec 100644</span><br><span>--- a/src/usb.c</span><br><span>+++ b/src/usb.c</span><br><span>@@ -36,6 +36,7 @@</span><br><span> </span><br><span> #include "e1d.h"</span><br><span> #include "log.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "ice1usb_proto.h"</span><br><span> </span><br><span> </span><br><span> #define USB_VID 0x1d50</span><br><span>@@ -57,6 +58,7 @@</span><br><span> uint8_t ep_in;</span><br><span> uint8_t ep_out;</span><br><span> uint8_t ep_fb;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t ep_int;</span><br><span> </span><br><span> /* Max packet size */</span><br><span> int pkt_size;</span><br><span>@@ -66,6 +68,12 @@</span><br><span> struct e1_usb_flow *flow_out;</span><br><span> struct e1_usb_flow *flow_fb;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Interrupt */</span><br><span style="color: hsl(120, 100%, 40%);">+ struct {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t buf[10];</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ice1usb_irq_err last_errcnt;</span><br><span style="color: hsl(120, 100%, 40%);">+ } irq;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Rate regulation */</span><br><span> uint32_t r_acc;</span><br><span> uint32_t r_sw;</span><br><span>@@ -98,8 +106,6 @@</span><br><span> struct e1_usb_flow_entry *entries;</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> // ---------------------------------------------------------------------------</span><br><span> // USB data transfer</span><br><span> // ---------------------------------------------------------------------------</span><br><span>@@ -275,6 +281,88 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+// ---------------------------------------------------------------------------</span><br><span style="color: hsl(120, 100%, 40%);">+// USB interrupt</span><br><span style="color: hsl(120, 100%, 40%);">+// ---------------------------------------------------------------------------</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int resubmit_irq(struct e1_line *line);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void rx_interrupt_errcnt(struct e1_line *line, const struct ice1usb_irq_err *errcnt)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1_usb_line_data *ld = (struct e1_usb_line_data *) line->drv_data;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ice1usb_irq_err *last = &ld->irq.last_errcnt;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (errcnt->crc != last->crc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "CRC error count %d (was %d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ errcnt->crc, last->crc);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (errcnt->align != last->align) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "ALIGNMENT error count %d (was %d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ errcnt->align, last->align);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (errcnt->ovfl != last->ovfl) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "OVERFLOW error count %d (was %d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ errcnt->ovfl, last->ovfl);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (errcnt->unfl != last->unfl) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "UNDERFLOW error count %d (was %d)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ errcnt->unfl, last->unfl);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if ((errcnt->flags & ICE1USB_ERR_F_ALIGN_ERR) != (last->flags & ICE1USB_ERR_F_ALIGN_ERR)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "ALIGNMENT %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ errcnt->flags & ICE1USB_ERR_F_ALIGN_ERR ? "LOST" : "REGAINED");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if ((errcnt->flags & ICE1USB_ERR_F_TICK_ERR) != (last->flags & ICE1USB_ERR_F_TICK_ERR)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "Rx Clock %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ errcnt->flags & ICE1USB_ERR_F_TICK_ERR ? "LOST" : "REGAINED");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ld->irq.last_errcnt = *errcnt;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void interrupt_ep_cb(struct libusb_transfer *xfer)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1_line *line = (struct e1_line *) xfer->user_data;</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct ice1usb_irq *irq = (const struct ice1usb_irq *) xfer->buffer;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!xfer->actual_length) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "Zero-Length Interrupt transfer\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (irq->type) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case ICE1USB_IRQQ_T_ERRCNT:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (xfer->actual_length < sizeof(*irq)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_ERROR, "Short ERRCNT interrupt: %u<%zu\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ xfer->actual_length, sizeof(*irq));</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_interrupt_errcnt(line, &irq->u.errors);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPLI(line, DE1D, LOGL_INFO, "Unsupported interrupt 0x%02x\n", irq->type);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+out:</span><br><span style="color: hsl(120, 100%, 40%);">+ resubmit_irq(line);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int resubmit_irq(struct e1_line *line)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1_usb_line_data *ld = (struct e1_usb_line_data *) line->drv_data;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1_usb_intf_data *id = (struct e1_usb_intf_data *) line->intf->drv_data;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct libusb_transfer *xfr = libusb_alloc_transfer(0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ libusb_fill_interrupt_transfer(xfr, id->devh, ld->ep_int, ld->irq.buf, sizeof(ld->irq.buf),</span><br><span style="color: hsl(120, 100%, 40%);">+ interrupt_ep_cb, line, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ return libusb_submit_transfer(xfr);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> // ---------------------------------------------------------------------------</span><br><span> // Init / Probing</span><br><span>@@ -316,7 +404,7 @@</span><br><span> continue;</span><br><span> </span><br><span> id = &cd->interface[i].altsetting[1];</span><br><span style="color: hsl(0, 100%, 40%);">- if ((id->bInterfaceClass != 0xff) || (id->bInterfaceSubClass != 0xe1) || (id->bNumEndpoints != 3))</span><br><span style="color: hsl(120, 100%, 40%);">+ if ((id->bInterfaceClass != 0xff) || (id->bInterfaceSubClass != 0xe1) || (id->bNumEndpoints < 3))</span><br><span> continue;</span><br><span> </span><br><span> /* Get interface and set it up */</span><br><span>@@ -353,6 +441,8 @@</span><br><span> else if (line_data->pkt_size != id->endpoint[j].wMaxPacketSize)</span><br><span> LOGP(DE1D, LOGL_ERROR, "Inconsistent max packet size %d vs %d\n",</span><br><span> line_data->pkt_size, (int)id->endpoint[j].wMaxPacketSize);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (id->endpoint[j].bmAttributes == 0x03) {</span><br><span style="color: hsl(120, 100%, 40%);">+ line_data->ep_int = id->endpoint[j].bEndpointAddress;</span><br><span> } else {</span><br><span> LOGP(DE1D, LOGL_ERROR, "Invalid EP %02x\n", id->endpoint[j].bEndpointAddress);</span><br><span> }</span><br><span>@@ -372,6 +462,9 @@</span><br><span> e1uf_start(line_data->flow_in);</span><br><span> e1uf_start(line_data->flow_out);</span><br><span> e1uf_start(line_data->flow_fb);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (line_data->ep_int)</span><br><span style="color: hsl(120, 100%, 40%);">+ resubmit_irq(line);</span><br><span> }</span><br><span> </span><br><span> return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21782">change 21782</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/21782"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5b0bf3cf40c623c17f2e88292e880b545c36b7b6 </div>
<div style="display:none"> Gerrit-Change-Number: 21782 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>