<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21789">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restriction"<br><br>This reverts commit c9eab828ea4a9f508a013cf5cc1e0384a0e62e4c.<br><br>The initial code was correct, which has also been used in osmo-bsc until<br>recently, where it moved to use this function from libosmocore and<br>errors started to show up in TTCN3 tests.<br><br>See 3GPP TS 44.018 Section 10.5.2.34 / Table 10.5.2.34.1: "SI 3 Rest<br>Octets information element":<br><br>"""<br><SI3 Rest Octet> ::=<br>...<br><3G Early Classmark Sending Restriction><br>...<br><br><3G Early Classmark Sending Restriction>::= L | H;<br>"""<br><br>Change-Id: I0ee48d3240c62c4d2e15063b26da7a2a617f383e<br>Related: OS#3075<br>Related: SYS#4021<br>---<br>M src/gsm/gsm48_rest_octets.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c</span><br><span>index 3a424f7..90f2b03 100644</span><br><span>--- a/src/gsm/gsm48_rest_octets.c</span><br><span>+++ b/src/gsm/gsm48_rest_octets.c</span><br><span>@@ -611,9 +611,9 @@</span><br><span>     /* 3G Early Classmark Sending Restriction. If H, then controlled by</span><br><span>   * early_cm_ctrl above */</span><br><span>    if (si3->early_cm_restrict_3g)</span><br><span style="color: hsl(0, 100%, 40%);">-               bitvec_set_bit(&bv, H);</span><br><span style="color: hsl(0, 100%, 40%);">-     else</span><br><span>                 bitvec_set_bit(&bv, L);</span><br><span style="color: hsl(120, 100%, 40%);">+   else</span><br><span style="color: hsl(120, 100%, 40%);">+          bitvec_set_bit(&bv, H);</span><br><span> </span><br><span>      if (si3->si2quater_indicator) {</span><br><span>           bitvec_set_bit(&bv, H); /* indicator struct present */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21789">change 21789</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21789"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0ee48d3240c62c4d2e15063b26da7a2a617f383e </div>
<div style="display:none"> Gerrit-Change-Number: 21789 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>