<p>daniel <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21692">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
lynxis lazus: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Add "show gbproxy cell ..." VTY command<br><br>This allows the user to inspect CELL related gb-proxy state.<br><br>Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5<br>---<br>M src/gbproxy/gb_proxy_vty.c<br>1 file changed, 42 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy_vty.c b/src/gbproxy/gb_proxy_vty.c</span><br><span>index fc2e8f1..595ac02 100644</span><br><span>--- a/src/gbproxy/gb_proxy_vty.c</span><br><span>+++ b/src/gbproxy/gb_proxy_vty.c</span><br><span>@@ -83,6 +83,32 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void gbproxy_vty_print_cell(struct vty *vty, struct gbproxy_cell *cell, bool show_stats)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gprs_ra_id raid;</span><br><span style="color: hsl(120, 100%, 40%);">+ gsm48_parse_ra(&raid, cell->ra);</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int num_sgsn_bvc = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int i;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "BVCI %5u RAI %s: ", cell->bvci, osmo_rai_name(&raid));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (cell->bss_bvc)</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "BSS NSEI %5u, SGSN NSEI ", cell->bss_bvc->nse->nsei);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "BSS NSEI <none>, SGSN NSEI ");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < ARRAY_SIZE(cell->sgsn_bvc); i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gbproxy_bvc *sgsn_bvc = cell->sgsn_bvc[i];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sgsn_bvc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%5u ", sgsn_bvc->nse->nsei);</span><br><span style="color: hsl(120, 100%, 40%);">+ num_sgsn_bvc++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (num_sgsn_bvc)</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "<none>%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static int config_write_gbproxy(struct vty *vty)</span><br><span> {</span><br><span> struct gbproxy_nse *nse;</span><br><span>@@ -222,6 +248,21 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(show_gbproxy_cell, show_gbproxy_cell_cmd, "show gbproxy cell [stats]",</span><br><span style="color: hsl(120, 100%, 40%);">+ SHOW_STR "Display information about the Gb proxy\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Show GPRS Cell Information\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Show statistics\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gbproxy_cell *cell;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool show_stats = argc >= 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ int i;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ hash_for_each(g_cfg->cells, i, cell, list)</span><br><span style="color: hsl(120, 100%, 40%);">+ gbproxy_vty_print_cell(vty, cell, show_stats);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(show_gbproxy_links, show_gbproxy_links_cmd, "show gbproxy links",</span><br><span> SHOW_STR "Display information about the Gb proxy\n" "Show logical links\n")</span><br><span> {</span><br><span>@@ -336,6 +377,7 @@</span><br><span> int gbproxy_vty_init(void)</span><br><span> {</span><br><span> install_element_ve(&show_gbproxy_bvc_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element_ve(&show_gbproxy_cell_cmd);</span><br><span> install_element_ve(&show_gbproxy_links_cmd);</span><br><span> install_element_ve(&logging_fltr_bvc_cmd);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21692">change 21692</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21692"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5 </div>
<div style="display:none"> Gerrit-Change-Number: 21692 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Assignee: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>