<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/include/osmocom/gprs/gprs_ns2.h">File include/osmocom/gprs/gprs_ns2.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/include/osmocom/gprs/gprs_ns2.h@45">Patch Set #18, Line 45:</a> <code style="font-family:monospace,monospace"> GPRS_NS2_LL_UNDEF, /*!< undefined used by vty */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">what do you mean here? "undefined use by vty"? or "undefined is used by bty"? If the second, simply […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">this sentence makes me smile. Even it wasn't meant that way.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_internal.h">File src/gb/gprs_ns2_internal.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_internal.h@188">Patch Set #18, Line 188:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">beautiful new spacing not related to the commit.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_sns.c">File src/gb/gprs_ns2_sns.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_sns.c@1541">Patch Set #18, Line 1541:</a> <code style="font-family:monospace,monospace"> * \param[in] stats Whether or not statistics shall also be printed */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">ninja param, not showing up in the function!</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">it's not often that the documentation precedes</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_sns.c@1554">Patch Set #18, Line 1554:</a> <code style="font-family:monospace,monospace"> vty_out(vty, " ip-sns %s %d%s", addr_str.ip, addr_str.port, VTY_NEWLINE);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">port is probably %u</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/4/src/gb/gprs_ns2_vty2.c">File src/gb/gprs_ns2_vty2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/4/src/gb/gprs_ns2_vty2.c@670">Patch Set #4, Line 670:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">"A unique bind identifier created by ns bind\n"<br> "Remote IPv4 Address\n" "Remote IPv6 Address\n"<br> "Remote UDP Port\n"<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">could also all be #defines as we need them multiple times, even in the same order</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_vty2.c">File src/gb/gprs_ns2_vty2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_vty2.c@232">Patch Set #15, Line 232:</a> <code style="font-family:monospace,monospace">/* TODO: create a function GPRS_NS2_LL_UDP -> udp function */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">don't we already have a value_string for that? we have get_string_value(), not just get_value_strin […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_vty2.c">File src/gb/gprs_ns2_vty2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_vty2.c@220">Patch Set #18, Line 220:</a> <code style="font-family:monospace,monospace">/* TODO: add fr/gre */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">what about this todo.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">fr/gre is a todo of the ns2 implementation. IMHO: without test equipment this isn't going to be implemented.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_vty2.c@362">Patch Set #18, Line 362:</a> <code style="font-family:monospace,monospace"> vty_out(vty, "nsvc udp %s %s %d%s",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">ports as %u?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/src/gb/gprs_ns2_vty2.c@408">Patch Set #18, Line 408:</a> <code style="font-family:monospace,monospace"> // TODO timer</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">this is missing?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21487">change 21487</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21487"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I163279cf57e84198dc8c53e1c109f5a9474670e9 </div>
<div style="display:none"> Gerrit-Change-Number: 21487 </div>
<div style="display:none"> Gerrit-PatchSet: 18 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 22 Dec 2020 12:24:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>