<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21838">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Fix confusing log message in gbprox_relay2nse<br><br>This function is now used to transmit messages in both directions,<br>BSS->SGSN and SGSN->BSS.<br>Print the actual direction in the logs<br><br>Change-Id: I31682156dfe88f7ca121a711968e625caed8bd5e<br>Related: OS#4472<br>---<br>M src/gbproxy/gb_proxy.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/38/21838/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c</span><br><span>index d84da1a..49841d2 100644</span><br><span>--- a/src/gbproxy/gb_proxy.c</span><br><span>+++ b/src/gbproxy/gb_proxy.c</span><br><span>@@ -145,11 +145,12 @@</span><br><span>      struct gprs_ns2_inst *nsi = nse->cfg->nsi;</span><br><span>     struct osmo_gprs_ns2_prim nsp = {};</span><br><span>  struct msgb *msg = bssgp_msgb_copy(old_msg, "msgb_relay2nse");</span><br><span style="color: hsl(120, 100%, 40%);">+      char log_pfx[32];</span><br><span>    uint32_t tlli;</span><br><span>       int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     DEBUGP(DGPRS, "NSE(%05u/SGSN)-BVC(%05u) proxying SGSN->BSS NSE(%05u/BSS)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-               msgb_nsei(msg), ns_bvci, nse->nsei);</span><br><span style="color: hsl(120, 100%, 40%);">+       snprintf(log_pfx, sizeof(log_pfx), "NSE(%05u/%s)-BVC(%05u/??)", msgb_nsei(msg), !nse->sgsn_facing ? "SGSN" : "BSS", ns_bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+        DEBUGP(DGPRS, "%s proxying to NSE(%05u/%s)\n", log_pfx, nse->nsei, nse->sgsn_facing ? "SGSN" : "BSS");</span><br><span> </span><br><span>       nsp.bvci = ns_bvci;</span><br><span>  nsp.nsei = nse->nsei;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21838">change 21838</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21838"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I31682156dfe88f7ca121a711968e625caed8bd5e </div>
<div style="display:none"> Gerrit-Change-Number: 21838 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>