<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/include/osmocom/gprs/gprs_ns2.h">File include/osmocom/gprs/gprs_ns2.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/18/include/osmocom/gprs/gprs_ns2.h@45">Patch Set #18, Line 45:</a> <code style="font-family:monospace,monospace">    GPRS_NS2_LL_UNDEF,      /*!< undefined used by vty */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">this sentence makes me smile. Even it wasn't meant that way.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">So then please improve the description.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/23/src/gb/gprs_ns2_vty2.c">File src/gb/gprs_ns2_vty2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21487/23/src/gb/gprs_ns2_vty2.c@1024">Patch Set #23, Line 1024:</a> <code style="font-family:monospace,monospace">      NSVCI_STR</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Are you sure this repeated NSVCI_STR belongs here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21487">change 21487</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21487"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I163279cf57e84198dc8c53e1c109f5a9474670e9 </div>
<div style="display:none"> Gerrit-Change-Number: 21487 </div>
<div style="display:none"> Gerrit-PatchSet: 23 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 22 Dec 2020 15:09:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>