<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21835">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">NS_Emulation.ttcnpp: complete SGSN emulation with SNS<br><br>The emulation of an SGSN with SNS was incomplete. The SNS<br>procedure was completed. However the NSVCs didn't moved<br>into an unblocked state.<br>Also sending a NS_ALIVE at the beginning is wrong.<br><br>Change-Id: I54c2d9d5b34d791be354298171d04180a9b263c3<br>---<br>M library/NS_Emulation.ttcnpp<br>1 file changed, 6 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/21835/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/NS_Emulation.ttcnpp b/library/NS_Emulation.ttcnpp</span><br><span>index 2ccd399..ba859b0 100644</span><br><span>--- a/library/NS_Emulation.ttcnpp</span><br><span>+++ b/library/NS_Emulation.ttcnpp</span><br><span>@@ -497,14 +497,8 @@</span><br><span>    * of the protocol, merely sufficient to make the PCU/BSS side happy to proceed */</span><br><span>   private altstep as_sns_sgsn() runs on NSVC_CT {</span><br><span>              var PDU_NS rf;</span><br><span style="color: hsl(0, 100%, 40%);">-          [g_config.role_sgsn] NSCP.receive(NS_Provider_Evt:{link_status:=NS_PROV_LINK_STATUS_UP}) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      log("Provider Link came up: sending NS-ALIVE");</span><br><span style="color: hsl(0, 100%, 40%);">-                       f_sendAlive();</span><br><span style="color: hsl(0, 100%, 40%);">-                  }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-               [not g_config.role_sgsn] NSCP.receive(NS_Provider_Evt:{link_status:=NS_PROV_LINK_STATUS_UP}) {</span><br><span style="color: hsl(0, 100%, 40%);">-                  log("Provider Link came up: sending NS-ALIVE");</span><br><span style="color: hsl(0, 100%, 40%);">-                       f_sendAlive();</span><br><span style="color: hsl(120, 100%, 40%);">+                [] NSCP.receive(NS_Provider_Evt:{link_status:=NS_PROV_LINK_STATUS_UP}) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      log("Provider Link came up. Waiting for SNS Size");</span><br><span>                        }</span><br><span> </span><br><span>                [] NSCP.receive(tr_SNS_SIZE(g_config.nsei)) -> value rf {</span><br><span>@@ -527,6 +521,10 @@</span><br><span>                  alt {</span><br><span>                        [] NSCP.receive(tr_SNS_CONFIG_ACK(g_config.nsei, omit)) {</span><br><span>                            /* success */</span><br><span style="color: hsl(120, 100%, 40%);">+                         log("SNS Config succeeded. Sending Alive");</span><br><span style="color: hsl(120, 100%, 40%);">+                         f_change_state(NSVC_S_ALIVE_UNBLOCKED);</span><br><span style="color: hsl(120, 100%, 40%);">+                               f_sendAlive();</span><br><span style="color: hsl(120, 100%, 40%);">+                                Tns_test.start;</span><br><span>                              }</span><br><span>                    [] NSCP.receive(tr_SNS_CONFIG_ACK(g_config.nsei, ?)) {</span><br><span>                               setverdict(fail, "Unexpected SNS-CONFIG-NACK");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21835">change 21835</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21835"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I54c2d9d5b34d791be354298171d04180a9b263c3 </div>
<div style="display:none"> Gerrit-Change-Number: 21835 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>