<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21791">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_rsl: turn rsl_msgb_alloc() a macro and move it to header<br><br>Also, take a chance to make talloc chunk names more informative.<br><br>Change-Id: Id25c4bf1e06f697328d10777d6449c83006e8466<br>---<br>M include/osmocom/bsc/abis_rsl.h<br>M src/osmo-bsc/abis_rsl.c<br>2 files changed, 7 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h</span><br><span>index 964e282..58eca29 100644</span><br><span>--- a/include/osmocom/bsc/abis_rsl.h</span><br><span>+++ b/include/osmocom/bsc/abis_rsl.h</span><br><span>@@ -35,6 +35,13 @@</span><br><span> </span><br><span> #define GSM48_LEN2PLEN(a)       (((a) << 2) | 1)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define RSL_ALLOC_SIZE              1024</span><br><span style="color: hsl(120, 100%, 40%);">+#define RSL_ALLOC_HEADROOM        128</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define rsl_msgb_alloc(args...) \</span><br><span style="color: hsl(120, 100%, 40%);">+      msgb_alloc_headroom(RSL_ALLOC_SIZE, RSL_ALLOC_HEADROOM, \</span><br><span style="color: hsl(120, 100%, 40%);">+                         __FILE__ ":" OSMO_STRINGIFY_VAL(__LINE__))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> const char *ip_to_a(uint32_t ip);</span><br><span> </span><br><span> int rsl_bcch_info(const struct gsm_bts_trx *trx, enum osmo_sysinfo_type si_type, const uint8_t *data, int len);</span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index f8ea5a5..a803a03 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -55,8 +55,6 @@</span><br><span> #include <osmocom/bsc/handover_fsm.h></span><br><span> #include <osmocom/bsc/smscb.h></span><br><span> #include <osmocom/bsc/bts.h></span><br><span style="color: hsl(0, 100%, 40%);">-#define RSL_ALLOC_SIZE          1024</span><br><span style="color: hsl(0, 100%, 40%);">-#define RSL_ALLOC_HEADROOM  128</span><br><span> </span><br><span> static void send_lchan_signal(int sig_no, struct gsm_lchan *lchan,</span><br><span>                              struct gsm_meas_rep *resp)</span><br><span>@@ -146,12 +144,6 @@</span><br><span>      return lchan;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static struct msgb *rsl_msgb_alloc(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- return msgb_alloc_headroom(RSL_ALLOC_SIZE, RSL_ALLOC_HEADROOM,</span><br><span style="color: hsl(0, 100%, 40%);">-                             "RSL");</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static void pad_macblock(uint8_t *out, const uint8_t *in, int len)</span><br><span> {</span><br><span>     memcpy(out, in, len);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21791">change 21791</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21791"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id25c4bf1e06f697328d10777d6449c83006e8466 </div>
<div style="display:none"> Gerrit-Change-Number: 21791 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>