<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21706">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  tnt: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">icE1usb fw: define e1_data_ptr() using e1_data_ofs()<br><br>It's best to compute the offset only at one place and use that<br>computation elsewhere.<br><br>Change-Id: I9a6cce07ea8b6eff1527215de00621da960b0472<br>---<br>M firmware/ice40-riscv/icE1usb/e1.c<br>1 file changed, 5 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>index e5108ce..776edba 100644</span><br><span>--- a/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>+++ b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>@@ -80,19 +80,17 @@</span><br><span> static volatile struct e1_core * const e1_regs = (void *)(E1_CORE_BASE);</span><br><span> static volatile uint8_t * const e1_data = (void *)(E1_DATA_BASE);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-volatile uint8_t *</span><br><span style="color: hsl(0, 100%, 40%);">-e1_data_ptr(int mf, int frame, int ts)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-     return &e1_data[(mf << 9) | (frame << 5) | ts];</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> unsigned int</span><br><span> e1_data_ofs(int mf, int frame, int ts)</span><br><span> {</span><br><span>      return (mf << 9) | (frame << 5) | ts;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+volatile uint8_t *</span><br><span style="color: hsl(120, 100%, 40%);">+e1_data_ptr(int mf, int frame, int ts)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     return &e1_data[e1_data_ofs(mf, frame, ts)];</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> // FIFOs</span><br><span> // -----</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21706">change 21706</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21706"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9a6cce07ea8b6eff1527215de00621da960b0472 </div>
<div style="display:none"> Gerrit-Change-Number: 21706 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>