<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21799">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_e1f: Fix inverted logic of E bits<br><br>A value of '1' means _no_ CRC4 error observed. We got that right<br>in the receive side, but not in the transmit side so far<br><br>Change-Id: I5ef9ef3b9781da2f53f54253d31cdbf81957ea67<br>---<br>M software/obsolete/osmo_e1f.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/software/obsolete/osmo_e1f.c b/software/obsolete/osmo_e1f.c</span><br><span>index a4cadb2..2c3fcfb 100644</span><br><span>--- a/software/obsolete/osmo_e1f.c</span><br><span>+++ b/software/obsolete/osmo_e1f.c</span><br><span>@@ -233,7 +233,7 @@</span><br><span>                 case 13:</span><br><span>             case 15:</span><br><span>                     ret = 0x40;</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (e1i->tx.crc4_error)</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (!e1i->tx.crc4_error)</span><br><span>                          ret |= 0x80;</span><br><span>                         break;</span><br><span>               }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21799">change 21799</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21799"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5ef9ef3b9781da2f53f54253d31cdbf81957ea67 </div>
<div style="display:none"> Gerrit-Change-Number: 21799 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>