<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21713">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">GPRS Cell Options (SI13): Add REL-4 CCN_ACTIVE bit<br><br>This is required in order to tell MS that osmo-pcu now supports<br>Network Assisted Cell Change (NACC).<br><br>Related: SYS#4909<br>Change-Id: I2aaa8c1107c977f711c2d7530034f57e36e3a237<br>---<br>M TODO-RELEASE<br>M include/osmocom/gprs/protocol/gsm_04_60.h<br>M src/gsm/gsm48_rest_octets.c<br>3 files changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index 7699aff..33e27af 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -8,5 +8,6 @@</span><br><span> # If any interfaces have been removed or changed since the last public release: c:r:0.</span><br><span> #library what description / commit summary line</span><br><span> libosmogsm new API gsm0808_create_sapi_reject_cause() with cause argument</span><br><span style="color: hsl(120, 100%, 40%);">+libosmogsm ABI change struct osmo_gprs_cell_options size changed (new field at the end)</span><br><span> libosmovty ABI change struct cmd_element: add a field for program specific attributes</span><br><span> libosmovty ABI change struct vty_app_info: optional program specific attributes description</span><br><span>diff --git a/include/osmocom/gprs/protocol/gsm_04_60.h b/include/osmocom/gprs/protocol/gsm_04_60.h</span><br><span>index 05728f4..ed63fe0 100644</span><br><span>--- a/include/osmocom/gprs/protocol/gsm_04_60.h</span><br><span>+++ b/include/osmocom/gprs/protocol/gsm_04_60.h</span><br><span>@@ -167,7 +167,7 @@</span><br><span> GPRS_NMO_III = 2, /* no paging coordination */</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* TS 04.60 12.24 */</span><br><span style="color: hsl(120, 100%, 40%);">+/* TS 44.060 12.24 */</span><br><span> struct osmo_gprs_cell_options {</span><br><span> enum osmo_gprs_nmo nmo;</span><br><span> /* T3168: wait for packet uplink assignment message */</span><br><span>@@ -187,6 +187,7 @@</span><br><span> uint8_t pfc_supported;</span><br><span> uint8_t dtm_supported;</span><br><span> uint8_t bss_paging_coordination;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool ccn_active;</span><br><span> } ext_info;</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c</span><br><span>index 1f9c2b5..3a424f7 100644</span><br><span>--- a/src/gsm/gsm48_rest_octets.c</span><br><span>+++ b/src/gsm/gsm48_rest_octets.c</span><br><span>@@ -906,6 +906,8 @@</span><br><span> bitvec_set_bit(bv, 0);</span><br><span> } else {</span><br><span> /* extension information */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* R99 extension: */</span><br><span> bitvec_set_bit(bv, 1);</span><br><span> if (!gco->ext_info.egprs_supported) {</span><br><span> /* 6bit length of extension */</span><br><span>@@ -927,6 +929,10 @@</span><br><span> bitvec_set_bit(bv, gco->ext_info.pfc_supported);</span><br><span> bitvec_set_bit(bv, gco->ext_info.dtm_supported);</span><br><span> bitvec_set_bit(bv, gco->ext_info.bss_paging_coordination);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* REL-4 extension: */</span><br><span style="color: hsl(120, 100%, 40%);">+ bitvec_set_bit(bv, gco->ext_info.ccn_active);</span><br><span style="color: hsl(120, 100%, 40%);">+ bitvec_set_bit(bv, 0); /* NW_EXT_UTBF disabled */</span><br><span> }</span><br><span> </span><br><span> return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21713">change 21713</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21713"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2aaa8c1107c977f711c2d7530034f57e36e3a237 </div>
<div style="display:none"> Gerrit-Change-Number: 21713 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>