<p>neels <strong>uploaded patch set #5</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21645">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_tests: add expected output<br><br>I am not sure whether we want to keep the expected log output of<br>handover tests in the source tree.<br><br>On the one hand, it is pretty nice to see how changes to the code affect<br>logging and the internal flow of things, and follow that in the history.<br>'make update_exp' makes it easy to update expected outputs.<br><br>On the other hand, those logs are a lot of cruft to keep. They will<br>often change as osmo-bsc changes. We've seen similar in the osmo-msc.git<br>msc_vlr_tests, I believe sometimes annoying some of us. The test script<br>only uses the expected log outputs when they are actually present, so it<br>is always an option for each developer to locally do 'make update_exp'<br>and diff between source versions like that, without the logs having to<br>be in version control.<br><br>I will leave it up to code review whether to add these logs or not.<br><br>Change-Id: I387aa62eb2dd9896494aefa32e6d336106e0ecdc<br>---<br>M tests/handover/handover_tests.sh<br>A tests/handover/test_amr_tch_f_to_h.ho_vty.err<br>A tests/handover/test_amr_tch_f_to_h.ho_vty.ok<br>A tests/handover/test_amr_tch_f_to_h_balance_congestion.ho_vty.err<br>A tests/handover/test_amr_tch_f_to_h_balance_congestion.ho_vty.ok<br>A tests/handover/test_amr_tch_f_to_h_congestion.ho_vty.err<br>A tests/handover/test_amr_tch_f_to_h_congestion.ho_vty.ok<br>A tests/handover/test_amr_tch_f_to_h_congestion_assignment.ho_vty.err<br>A tests/handover/test_amr_tch_f_to_h_congestion_assignment.ho_vty.ok<br>A tests/handover/test_amr_tch_f_to_h_congestion_assignment_2.ho_vty.err<br>A tests/handover/test_amr_tch_f_to_h_congestion_assignment_2.ho_vty.ok<br>A tests/handover/test_amr_tch_f_to_h_congestion_assignment_3.ho_vty.err<br>A tests/handover/test_amr_tch_f_to_h_congestion_assignment_3.ho_vty.ok<br>A tests/handover/test_balance_congestion.ho_vty.err<br>A tests/handover/test_balance_congestion.ho_vty.ok<br>A tests/handover/test_balance_congestion_2.ho_vty.err<br>A tests/handover/test_balance_congestion_2.ho_vty.ok<br>A tests/handover/test_congestion.ho_vty.err<br>A tests/handover/test_congestion.ho_vty.ok<br>A tests/handover/test_disabled_ho_and_as.ho_vty.err<br>A tests/handover/test_disabled_ho_and_as.ho_vty.ok<br>A tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty.err<br>A tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty.ok<br>A tests/handover/test_dyn_ts_favor_half_used_tch_h_as_target.ho_vty.err<br>A tests/handover/test_dyn_ts_favor_half_used_tch_h_as_target.ho_vty.ok<br>A tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty.err<br>A tests/handover/test_dyn_ts_favor_moving_half_used_tch_h.ho_vty.ok<br>A tests/handover/test_ho_to_better_cell.ho_vty.err<br>A tests/handover/test_ho_to_better_cell.ho_vty.ok<br>A tests/handover/test_ho_to_better_cell_2.ho_vty.err<br>A tests/handover/test_ho_to_better_cell_2.ho_vty.ok<br>A tests/handover/test_hysteresis.ho_vty.err<br>A tests/handover/test_hysteresis.ho_vty.ok<br>A tests/handover/test_insufficient_measurements.ho_vty.err<br>A tests/handover/test_insufficient_measurements.ho_vty.ok<br>A tests/handover/test_keep_efr_codec.ho_vty.err<br>A tests/handover/test_keep_efr_codec.ho_vty.ok<br>A tests/handover/test_keep_fr_codec.ho_vty.err<br>A tests/handover/test_keep_fr_codec.ho_vty.ok<br>A tests/handover/test_keep_hr_codec.ho_vty.err<br>A tests/handover/test_keep_hr_codec.ho_vty.ok<br>A tests/handover/test_max_handovers.ho_vty.err<br>A tests/handover/test_max_handovers.ho_vty.ok<br>A tests/handover/test_max_ta.ho_vty.err<br>A tests/handover/test_max_ta.ho_vty.ok<br>A tests/handover/test_min_rxlev_vs_congestion.ho_vty.err<br>A tests/handover/test_min_rxlev_vs_congestion.ho_vty.ok<br>A tests/handover/test_min_rxlev_vs_hysteresis.ho_vty.err<br>A tests/handover/test_min_rxlev_vs_hysteresis.ho_vty.ok<br>A tests/handover/test_neighbor_congested.ho_vty.err<br>A tests/handover/test_neighbor_congested.ho_vty.ok<br>A tests/handover/test_neighbor_full.ho_vty.err<br>A tests/handover/test_neighbor_full.ho_vty.ok<br>A tests/handover/test_no_congestion.ho_vty.err<br>A tests/handover/test_no_congestion.ho_vty.ok<br>A tests/handover/test_penalty_timer.ho_vty.err<br>A tests/handover/test_penalty_timer.ho_vty.ok<br>A tests/handover/test_rxqual.ho_vty.err<br>A tests/handover/test_rxqual.ho_vty.ok<br>A tests/handover/test_rxqual_vs_congestion.ho_vty.err<br>A tests/handover/test_rxqual_vs_congestion.ho_vty.ok<br>A tests/handover/test_stay_in_better_cell.ho_vty.err<br>A tests/handover/test_stay_in_better_cell.ho_vty.ok<br>A tests/handover/test_stay_in_better_cell_2.ho_vty.err<br>A tests/handover/test_stay_in_better_cell_2.ho_vty.ok<br>A tests/handover/test_story.ho_vty.err<br>A tests/handover/test_story.ho_vty.ok<br>67 files changed, 14,860 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/21645/5</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21645">change 21645</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21645"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I387aa62eb2dd9896494aefa32e6d336106e0ecdc </div>
<div style="display:none"> Gerrit-Change-Number: 21645 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>