<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/21729">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: follow changes to add a unique name to all binds<br><br>Related: OS#4472, OS#4890<br>Depends: libosmocore.git I8f1d66b7b3b12da12db8b5e6bd08c1beff085b3e<br>Change-Id: I3638c7204db576116ba2e20dae27539ce6143bd7<br>---<br>M src/gprs_bssgp_pcu.cpp<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp</span><br><span>index 4d24d2e..b29413d 100644</span><br><span>--- a/src/gprs_bssgp_pcu.cpp</span><br><span>+++ b/src/gprs_bssgp_pcu.cpp</span><br><span>@@ -957,6 +957,7 @@</span><br><span>      bool nsvcs = false;</span><br><span>  struct gprs_ns2_vc *nsvc;</span><br><span>    struct gprs_ns2_vc_bind *bind[PCU_IF_NUM_NSVC] = { };</span><br><span style="color: hsl(120, 100%, 40%);">+ char name[5];</span><br><span> </span><br><span>    if (!valid)</span><br><span>          return -1;</span><br><span>@@ -966,7 +967,8 @@</span><br><span>                     continue;</span><br><span> </span><br><span>                if (!gprs_ns2_ip_bind_by_sockaddr(bts->nsi, &local[i])) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        rc = gprs_ns2_ip_bind(bts->nsi, &local[i], 0, &bind[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+                   snprintf(name, sizeof(name), "pcu%d", i);</span><br><span style="color: hsl(120, 100%, 40%);">+                   rc = gprs_ns2_ip_bind(bts->nsi, name, &local[i], 0, &bind[i]);</span><br><span>                    if (rc < 0) {</span><br><span>                             LOGP(DBSSGP, LOGL_ERROR, "Failed to bind to %s\n", osmo_sockaddr_to_str(&local[i]));</span><br><span>                           continue;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/21729">change 21729</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/21729"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3638c7204db576116ba2e20dae27539ce6143bd7 </div>
<div style="display:none"> Gerrit-Change-Number: 21729 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>