<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21747">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_vty: udp: fixup dialect changes<br><br>Only accept receiving ipaccess style messages when use-reset-block<br>is selected.<br>If use-reset-block is disabled allow static NSVCs.<br><br>Change-Id: Ia787528b1a6fac6bf1570c21643ef6cd8c209108<br>---<br>M src/gb/gprs_ns2_vty.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index 742f181..e33869b 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -901,7 +901,8 @@</span><br><span>                      /* TODO: could not bind on the specific address */</span><br><span>                   return -1;</span><br><span>           }</span><br><span style="color: hsl(0, 100%, 40%);">-               bind->accept_ipaccess = true;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+            bind->accept_ipaccess = priv.vc_mode == NS2_VC_MODE_BLOCKRESET;</span><br><span>   }</span><br><span> </span><br><span>        /* create vcs */</span><br><span>@@ -909,7 +910,10 @@</span><br><span>              /* validate settings */</span><br><span>              switch (vtyvc->ll) {</span><br><span>              case GPRS_NS2_LL_UDP:</span><br><span style="color: hsl(0, 100%, 40%);">-                   dialect = NS2_DIALECT_IPACCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (priv.vc_mode == NS2_VC_MODE_BLOCKRESET)</span><br><span style="color: hsl(120, 100%, 40%);">+                           dialect = NS2_DIALECT_IPACCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+                       else</span><br><span style="color: hsl(120, 100%, 40%);">+                          dialect = NS2_DIALECT_STATIC_ALIVE;</span><br><span>                  if (strlen(vtyvc->remote.ip) == 0) {</span><br><span>                              /* Invalid IP for VC */</span><br><span>                              continue;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21747">change 21747</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21747"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia787528b1a6fac6bf1570c21643ef6cd8c209108 </div>
<div style="display:none"> Gerrit-Change-Number: 21747 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>