<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21733">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">icE1usb fw: Turn green LED off completely if no E1 signal is received<br><br>We don't really have an idea of the analog signal level and hence<br>no true LOS detection.  However, we can check the Rx clock tick counter<br>to detect if there is at least still any kind of signal at all or not.<br><br>Change-Id: Ibd23cbf1d044b46d8fed48fb97622e6ef980b99f<br>---<br>M doc/manuals/chapters/firmware.adoc<br>M firmware/ice40-riscv/icE1usb/e1.c<br>2 files changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/33/21733/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc</span><br><span>index 254e235..798f5f4 100644</span><br><span>--- a/doc/manuals/chapters/firmware.adoc</span><br><span>+++ b/doc/manuals/chapters/firmware.adoc</span><br><span>@@ -135,6 +135,7 @@</span><br><span> [options="header"]</span><br><span> |===</span><br><span> |Color  | Pattern         | Meaning</span><br><span style="color: hsl(120, 100%, 40%);">+|Green  | Off             | E1 Receiver detects no signal</span><br><span> |Green  | Blinking (slow) | E1 Receiver attempting to align</span><br><span> |Green  | On              | E1 Receiver fully aligned</span><br><span> |===</span><br><span>diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>index 9ad2798..6f85d19 100644</span><br><span>--- a/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>+++ b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>@@ -16,6 +16,8 @@</span><br><span> #include "dma.h"</span><br><span> #include "led.h" // FIXME</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include "misc.h"   // needed to get the E1 tick for "LOS" detection</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> // Hardware</span><br><span> // --------</span><br><span>@@ -283,6 +285,7 @@</span><br><span>                 struct e1_fifo fifo;</span><br><span>                 int in_flight;</span><br><span>               enum e1_pipe_state state;</span><br><span style="color: hsl(120, 100%, 40%);">+             uint16_t last_tick;</span><br><span>  } rx;</span><br><span> </span><br><span>    struct {</span><br><span>@@ -426,8 +429,12 @@</span><br><span>              e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_ON);</span><br><span>                led_color(0, 48, 0);</span><br><span>         } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK);</span><br><span style="color: hsl(0, 100%, 40%);">-                /* TODO: completely off if rx tick counter not incrementing */</span><br><span style="color: hsl(120, 100%, 40%);">+                uint16_t cur_tick = e1_tick_read(0);</span><br><span style="color: hsl(120, 100%, 40%);">+          if (g_e1.rx.last_tick == cur_tick)</span><br><span style="color: hsl(120, 100%, 40%);">+                    e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_OFF);</span><br><span style="color: hsl(120, 100%, 40%);">+                else</span><br><span style="color: hsl(120, 100%, 40%);">+                  e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK);</span><br><span style="color: hsl(120, 100%, 40%);">+              g_e1.rx.last_tick = cur_tick;</span><br><span>                led_color(48, 0, 0);</span><br><span>         }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21733">change 21733</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21733"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibd23cbf1d044b46d8fed48fb97622e6ef980b99f </div>
<div style="display:none"> Gerrit-Change-Number: 21733 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>