<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/21263">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/21263/6/osmo-ran/Dockerfile">File osmo-ran/Dockerfile:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/21263/6/osmo-ran/Dockerfile@42">Patch Set #6, Line 42:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">           less \<br>                        apt-utils \<br>                   strace \<br>                      tcpdump \<br>                     telnet \<br>                      vim \<br>                 osmo-bsc \<br>                    osmo-bsc-ipaccess-utils \<br>                     osmo-bts-trx \<br>                        osmo-mgw \<br>                    osmo-pcu \<br>                    osmo-trx-ipc \<br>                        osmo-trx-uhd && \<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">except of apt-utils the two lists seem identical.  Might make sense to keep the common list of packages in some variable and then use it in both clauses? Not critical, but would IMHO increase maintainability and have less risk of breaking only either of the two at some later change.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/21263">change 21263</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/21263"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If5d22e9fa818310cbb4adc34bd7aceb4416ec969 </div>
<div style="display:none"> Gerrit-Change-Number: 21263 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 11 Dec 2020 10:07:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>