<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2: Code-Review+1</p><p style="white-space: pre-wrap; word-wrap: break-word;">Wouldn't it make sense to handle this inside the macro/inline-functions?</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you check inside nm_bb_transc_fsm_state_chg(), then you don't have to change the callers, and it would be a genric solution.</p><p style="white-space: pre-wrap; word-wrap: break-word;">In fact, we could even consider introducing an osmo_fsm flag that would make such transitions quiet for certain fsm "classes" that set the flag.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I am not sure if blocking loop-transitions is valid for all other states. Maybe in some state(s) it's expected to leave and enter the same state again to re-initialize something?</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21607">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21607">change 21607</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21607"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I24a78905bb684f8501dc5ade0605662ec283febc </div>
<div style="display:none"> Gerrit-Change-Number: 21607 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 10 Dec 2020 13:05:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>