<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21567">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OsmoCtrl: use one global common counter for CTRL IDs<br><br>It is easier to traverse debugging logs if the CTRL request and response<br>IDs are globally unique across all programs and tests. Before this, we<br>were using 0 almost everywhere.<br><br>(This is not strictly needed for correctness, since each CTRL client has<br>its own request ID scope; just we open fairly many separate CTRL clients<br>all the time in our tests.)<br><br>Change-Id: I44c51f4fb5beb6cedf98ea0d6684a24c6aa418c7<br>---<br>M src/osmo_gsm_tester/obj/osmo_ctrl.py<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/obj/osmo_ctrl.py b/src/osmo_gsm_tester/obj/osmo_ctrl.py</span><br><span>index 6c4ac87..3098960 100644</span><br><span>--- a/src/osmo_gsm_tester/obj/osmo_ctrl.py</span><br><span>+++ b/src/osmo_gsm_tester/obj/osmo_ctrl.py</span><br><span>@@ -39,17 +39,17 @@</span><br><span>     pass</span><br><span> </span><br><span> class OsmoCtrl(log.Origin):</span><br><span style="color: hsl(120, 100%, 40%);">+    _next_id = 1</span><br><span> </span><br><span>     def __init__(self, host, port):</span><br><span>         super().__init__(log.C_BUS, 'Ctrl', host=host, port=port)</span><br><span>         self.host = host</span><br><span>         self.port = port</span><br><span>         self.sck = None</span><br><span style="color: hsl(0, 100%, 40%);">-        self._next_id = 0</span><br><span> </span><br><span>     def next_id(self):</span><br><span style="color: hsl(0, 100%, 40%);">-        ret = self._next_id</span><br><span style="color: hsl(0, 100%, 40%);">-        self._next_id += 1</span><br><span style="color: hsl(120, 100%, 40%);">+        ret = OsmoCtrl._next_id</span><br><span style="color: hsl(120, 100%, 40%);">+        OsmoCtrl._next_id += 1</span><br><span>         return ret</span><br><span> </span><br><span>     def prefix_ipa_ctrl_header(self, data):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21567">change 21567</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21567"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I44c51f4fb5beb6cedf98ea0d6684a24c6aa418c7 </div>
<div style="display:none"> Gerrit-Change-Number: 21567 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>