<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21450">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: fix dump_lchan_trx_ts(): dump dedicated channels only<br><br>It does not make sense to dump CCCH/CBCH as dedicated channels:<br><br>  OsmoBTS# show lchan<br>  BTS 0, TRX 0, Timeslot 0, Lchan 4: Type CCCH<br>    State: ACTIVE<br>    BS (Downlink) Power Control (autonomous):<br>      Channel reduction: 0 dB (max 0 dB)<br>      TRX reduction: 0 dB<br>      Actual / Nominal power: 13 dBm / 13 dBm<br>    MS (Uplink) Power Control (autonomous):<br>      Current power level: 0, -39 dBm (max 0, -39 dBm)<br>    Channel Mode / Codec: SIGNALLING<br>    LAPDm SAPIs: DCCH --, SACCH --<br>    Valid System Information: 0x00000060<br>    MS Timing Offset: 0, propagation delay: 0 symbols<br>    Radio Link Failure Counter 'S': 0<br><br>so let's only dump SDCCH, TCH/F, and TCH/H.<br><br>Change-Id: Id7880de56a93cc9fa4ca576b094cef35ee269822<br>---<br>M src/common/vty.c<br>1 file changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index ada871a..7284bfa 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -1449,7 +1449,15 @@</span><br><span>               const struct gsm_lchan *lchan = &ts->lchan[lchan_nr];</span><br><span>                 if (lchan->state == LCHAN_S_NONE)</span><br><span>                         continue;</span><br><span style="color: hsl(0, 100%, 40%);">-               dump_cb(vty, lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+          switch (lchan->type) {</span><br><span style="color: hsl(120, 100%, 40%);">+             case GSM_LCHAN_SDCCH:</span><br><span style="color: hsl(120, 100%, 40%);">+         case GSM_LCHAN_TCH_F:</span><br><span style="color: hsl(120, 100%, 40%);">+         case GSM_LCHAN_TCH_H:</span><br><span style="color: hsl(120, 100%, 40%);">+                 dump_cb(vty, lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+                  break;</span><br><span style="color: hsl(120, 100%, 40%);">+                default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      continue;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>    }</span><br><span> </span><br><span>        return CMD_SUCCESS;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21450">change 21450</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21450"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id7880de56a93cc9fa4ca576b094cef35ee269822 </div>
<div style="display:none"> Gerrit-Change-Number: 21450 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>