<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21509">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log passed tests<br><br>In the end of a test suite, do not omit the passed tests. For example,<br>running handover against N BTS combinations, it was hard to summarize<br>which BTS models actually succeeded, with only the failures listed.<br><br>Besides the "FAIL" listings, now print something like this in the end:<br><br> PASS: handover:sysmo+secondbts-trx-b200 (pass: 1)<br>     pass: handover.py (198.8 sec)<br> PASS: handover:sysmo+secondbts-trx-umtrx (pass: 1)<br>     pass: handover.py (192.7 sec)<br> PASS: handover:trx-b200+secondbts-trx-umtrx (pass: 1)<br>     pass: handover.py (193.1 sec)<br><br>Change-Id: Ib85a5b90e267c2ed2f844691187ecadc8939b1bb<br>---<br>M src/osmo_gsm_tester/core/report.py<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/core/report.py b/src/osmo_gsm_tester/core/report.py</span><br><span>index d2c68c5..c3390fe 100644</span><br><span>--- a/src/osmo_gsm_tester/core/report.py</span><br><span>+++ b/src/osmo_gsm_tester/core/report.py</span><br><span>@@ -164,12 +164,14 @@</span><br><span>     return testcase</span><br><span> </span><br><span> def trial_to_text(trial):</span><br><span style="color: hsl(120, 100%, 40%);">+    suite_passes = []</span><br><span>     suite_failures = []</span><br><span>     count_fail = 0</span><br><span>     count_pass = 0</span><br><span>     for suite in trial.suites:</span><br><span>         if suite.passed():</span><br><span>             count_pass += 1</span><br><span style="color: hsl(120, 100%, 40%);">+            suite_passes.append(suite_to_text(suite))</span><br><span>         else:</span><br><span>             count_fail += 1</span><br><span>             suite_failures.append(suite_to_text(suite))</span><br><span>@@ -181,6 +183,7 @@</span><br><span>         summary.append('%d suites passed' % count_pass)</span><br><span>     msg = [', '.join(summary)]</span><br><span>     msg.extend(suite_failures)</span><br><span style="color: hsl(120, 100%, 40%);">+    msg.extend(suite_passes)</span><br><span>     return '\n'.join(msg)</span><br><span> </span><br><span> def suite_to_text(suite):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21509">change 21509</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21509"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib85a5b90e267c2ed2f844691187ecadc8939b1bb </div>
<div style="display:none"> Gerrit-Change-Number: 21509 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>