<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21618">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_sns: correct dynamic calculation<br><br>The wrong argument was used to multiply by 4. However it was still<br>compliant because the SNS code would always supports 16 NSVCs.<br>Use the correct multiplier.<br><br>Fixes: ttnc3 pcu sns test cases<br>Fixes: 42ad54915285 ("gprs_ns2_sns: dynamic calculate the maximum NS-VCs")<br><br>Change-Id: I58d706c6fffb4237b90b37cade4dc00c6aba6ac9<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index d13d920..5d18d04 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -1320,7 +1320,7 @@</span><br><span> </span><br><span>           gss->num_ip4_local = count;</span><br><span>               gss->num_max_ip4_remote = 4;</span><br><span style="color: hsl(0, 100%, 40%);">-         gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip4_remote * 4, 8);</span><br><span style="color: hsl(120, 100%, 40%);">+          gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip4_remote * gss->num_ip4_local, 8);</span><br><span>             break;</span><br><span>       case IPv6:</span><br><span>           /* IPv6 */</span><br><span>@@ -1359,7 +1359,7 @@</span><br><span>           }</span><br><span>            gss->num_ip6_local = count;</span><br><span>               gss->num_max_ip6_remote = 4;</span><br><span style="color: hsl(0, 100%, 40%);">-         gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip6_remote * 4, 8);</span><br><span style="color: hsl(120, 100%, 40%);">+          gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip6_remote * gss->num_ip6_local, 8);</span><br><span>             break;</span><br><span>       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21618">change 21618</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21618"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I58d706c6fffb4237b90b37cade4dc00c6aba6ac9 </div>
<div style="display:none"> Gerrit-Change-Number: 21618 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>