<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21609">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tlv.h: Add msgb_tvlv_put_{16,32}be()<br><br>Those routines are very useful when puzzling together BSSGP messages<br>with 16-bit and 32bit sized IEs.<br><br>Change-Id: I033f9a708c9d7ffad91336178231dc66233e1693<br>---<br>M include/osmocom/gsm/tlv.h<br>1 file changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h</span><br><span>index d34b7da..fe057f4 100644</span><br><span>--- a/include/osmocom/gsm/tlv.h</span><br><span>+++ b/include/osmocom/gsm/tlv.h</span><br><span>@@ -4,6 +4,7 @@</span><br><span> #include <string.h></span><br><span> </span><br><span> #include <osmocom/core/msgb.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/byteswap.h></span><br><span> #include <osmocom/core/bit16gen.h></span><br><span> #include <osmocom/core/bit32gen.h></span><br><span> </span><br><span>@@ -278,6 +279,20 @@</span><br><span>         return tvlv_put(buf, tag, len, val);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! put (append) a TvLV field containing a big-endian 16bit value to msgb. */</span><br><span style="color: hsl(120, 100%, 40%);">+static inline uint8_t *msgb_tvlv_put_16be(struct msgb *msg, uint8_t tag, uint16_t val)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+       uint16_t val_be = osmo_htons(val);</span><br><span style="color: hsl(120, 100%, 40%);">+    return msgb_tvlv_put(msg, tag, 2, (const uint8_t *)&val_be);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*! put (append) a TvLV field containing a big-endian 16bit value to msgb. */</span><br><span style="color: hsl(120, 100%, 40%);">+static inline uint8_t *msgb_tvlv_put_32be(struct msgb *msg, uint8_t tag, uint32_t val)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+       uint32_t val_be = osmo_htonl(val);</span><br><span style="color: hsl(120, 100%, 40%);">+    return msgb_tvlv_put(msg, tag, 4, (const uint8_t *)&val_be);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! put (append) a vTvLV field to \ref msgb */</span><br><span> static inline uint8_t *msgb_vtvlv_gan_put(struct msgb *msg, uint16_t tag,</span><br><span>                                           uint16_t len, const uint8_t *val)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21609">change 21609</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21609"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I033f9a708c9d7ffad91336178231dc66233e1693 </div>
<div style="display:none"> Gerrit-Change-Number: 21609 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>