<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c">File src/gb/bssgp_bvc_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c@4">Patch Set #6, Line 4:</a> <code style="font-family:monospace,monospace">/* FIXME: This should probably be moved to libosmogb? */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Isn't it?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also license seems to be missing here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c@238">Patch Set #6, Line 238:</a> <code style="font-family:monospace,monospace">     bfp->features.negotiated = bfp->features.advertised & features_rx;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing bfp->features.received = features_rx;</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/bssgp_bvc_fsm.c@650">Patch Set #6, Line 650:</a> <code style="font-family:monospace,monospace">    OSMO_ASSERT(bvci >= 2);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">OSMO_ASSERT(ra_id) as well</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c">File src/gb/gprs_bssgp2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c@3">Patch Set #6, Line 3:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">License?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c@11">Patch Set #6, Line 11:</a> <code style="font-family:monospace,monospace">//#include <osmocom/gprs/gprs_msgb.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/6/src/gb/gprs_bssgp2.c@71">Patch Set #6, Line 71:</a> <code style="font-family:monospace,monospace">BVC-BLOCK</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">*BLOCK-ACK</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21598">change 21598</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21598"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icbe8e4f03b68fd73b8eae95f6f6cccd4fa9af95a </div>
<div style="display:none"> Gerrit-Change-Number: 21598 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 09 Dec 2020 16:13:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>