<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21625">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved; Verified
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nm_channel_fsm: Fix several FSM internal transitions not being made<br><br>During the initial implementation I used the wrong function to change<br>state. As a result, from BSC point of view the BTS was changing state<br>but the FSM internally was not. "Fortunately", while in state Dependency<br>the BTS still could cope with that in order to still be operative with<br>older osmo-bsc, so there was no major breakage, only some error log<br>message being printed.<br><br>Related: OS#4873<br>Change-Id: Ifd2eefc362fca0aa9e6ae102c7e6dbc1b4f295d6<br>---<br>M src/common/nm_channel_fsm.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/nm_channel_fsm.c b/src/common/nm_channel_fsm.c</span><br><span>index 263d2cc..4925959 100644</span><br><span>--- a/src/common/nm_channel_fsm.c</span><br><span>+++ b/src/common/nm_channel_fsm.c</span><br><span>@@ -92,7 +92,7 @@</span><br><span>            oml_mo_opstart_nack(&ts->mo, (int)(intptr_t)data);</span><br><span>            return;</span><br><span>      case NM_EV_BBTRANSC_ENABLED:</span><br><span style="color: hsl(0, 100%, 40%);">-            oml_mo_state_chg(&ts->mo, NM_OPSTATE_DISABLED, NM_AVSTATE_OFF_LINE);</span><br><span style="color: hsl(120, 100%, 40%);">+           nm_chan_fsm_state_chg(fi, NM_CHAN_ST_OP_DISABLED_OFFLINE);</span><br><span>           return;</span><br><span>      default:</span><br><span>             OSMO_ASSERT(0);</span><br><span>@@ -121,7 +121,7 @@</span><br><span>                oml_mo_opstart_nack(&ts->mo, (int)(intptr_t)data);</span><br><span>            return;</span><br><span>      case NM_EV_BBTRANSC_DISABLED:</span><br><span style="color: hsl(0, 100%, 40%);">-           oml_mo_state_chg(&ts->mo, NM_OPSTATE_DISABLED, NM_AVSTATE_DEPENDENCY);</span><br><span style="color: hsl(120, 100%, 40%);">+         nm_chan_fsm_state_chg(fi, NM_CHAN_ST_OP_DISABLED_DEPENDENCY);</span><br><span>                return;</span><br><span>      default:</span><br><span>             OSMO_ASSERT(0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21625">change 21625</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21625"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifd2eefc362fca0aa9e6ae102c7e6dbc1b4f295d6 </div>
<div style="display:none"> Gerrit-Change-Number: 21625 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>