<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/3//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/3//COMMIT_MSG@18">Patch Set #3, Line 18:</a> <code style="font-family:monospace,monospace">bssgp_bvc_fsm.c is a genric implementation of the BSSGP BVC</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">generic</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c">File src/gb/bssgp_bvc_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c@4">Patch Set #3, Line 4:</a> <code style="font-family:monospace,monospace">/* FIXME: This should probably be moved to libosmogb? */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">it's already inlibosmogb right?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c@70">Patch Set #3, Line 70:</a> <code style="font-family:monospace,monospace">              uint32_t advertised;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">not important, but these can really be uint16_t then.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c@283">Patch Set #3, Line 283:</a> <code style="font-family:monospace,monospace">               osmo_fsm_inst_state_chg(fi, BSSGP_BVCFSM_S_UNBLOCKED, T1_SECS, T1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not required, but you probably want to move to using osmo_tdef structures and FSM APIs at some point, so that timers are hooked transparently to state changes.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21598">change 21598</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21598"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icbe8e4f03b68fd73b8eae95f6f6cccd4fa9af95a </div>
<div style="display:none"> Gerrit-Change-Number: 21598 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 08 Dec 2020 10:58:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>