<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21576">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">WIP: gprs_ns2_vty2: improve ip-sns implementation<br><br>Change-Id: I741f21c36f1074e99304d51d96e1c00be24cf3c6<br>---<br>M src/gb/gprs_ns2_vty2.c<br>1 file changed, 26 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/21576/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty2.c b/src/gb/gprs_ns2_vty2.c</span><br><span>index 5604183..fa6a7c4 100644</span><br><span>--- a/src/gb/gprs_ns2_vty2.c</span><br><span>+++ b/src/gb/gprs_ns2_vty2.c</span><br><span>@@ -1007,6 +1007,7 @@</span><br><span> struct gprs_ns2_nse *nse = vty->index;</span><br><span> bool dialect_modified = false;</span><br><span> bool ll_modified = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span> </span><br><span> const char *bindgroup = argv[0];</span><br><span> struct osmo_sockaddr_str remote_str;</span><br><span>@@ -1043,9 +1044,17 @@</span><br><span> goto err;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO add */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = gprs_ns2_sns_add_endpoint(nse, &remote);</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (rc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0:</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+ case -EADDRINUSE:</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "Specified SNS endpoint already part of the NSE.%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "Can not add specified SNS endpoint.%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> err:</span><br><span> if (ll_modified)</span><br><span>@@ -1070,6 +1079,7 @@</span><br><span> struct osmo_sockaddr_str remote_str; /* argv[2] */</span><br><span> struct osmo_sockaddr remote;</span><br><span> uint16_t port = atoi(argv[3]);</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span> </span><br><span> if (nse->ll != GPRS_NS2_LL_UDP) {</span><br><span> vty_out(vty, "This NSE doesn't support UDP.%s", VTY_NEWLINE);</span><br><span>@@ -1098,6 +1108,19 @@</span><br><span> return CMD_WARNING;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ rc = gprs_ns2_sns_del_endpoint(nse, &remote);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "Can not remove specified SNS endpoint.%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO:</span><br><span style="color: hsl(120, 100%, 40%);">+ * - check if sns has endpoints</span><br><span style="color: hsl(120, 100%, 40%);">+ * - if !empty -> CMD SUCCESS</span><br><span style="color: hsl(120, 100%, 40%);">+ * - remove sns fsm</span><br><span style="color: hsl(120, 100%, 40%);">+ * - set to LL/DIALECT to undef</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if (llist_empty(&nse->nsvc)) {</span><br><span> nse->ll = GPRS_NS2_LL_UNDEF;</span><br><span> nse->dialect = NS2_DIALECT_UNDEF;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21576">change 21576</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21576"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I741f21c36f1074e99304d51d96e1c00be24cf3c6 </div>
<div style="display:none"> Gerrit-Change-Number: 21576 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>