<p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21544">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c">File src/gb/gprs_bssgp_util.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21544/1/src/gb/gprs_bssgp_util.c@209">Patch Set #1, Line 209:</a> <code style="font-family:monospace,monospace">static const uint8_t crt_bss_pfc_nack_ies[] = { BSSGP_IE_TLLI, BSSGP_IE_PACKET_FLOW_ID, BSSGP_IE_CAUSE };</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I'm not sure I understand your suggestion. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">#define DECLR_TLV_IE(name) static const uint8_t name_ies<br>#define DEF_TLV_IE(name, str) [name] = MSG_DEF(str, name_ies),</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>Then, for instance:</p><p style="white-space: pre-wrap; word-wrap: break-word;">DECLR_TLV_IE(BSSGP_PDUT_DL_UNITDATA) = { BSSGP_IE_PDU_LIFETIME };<br>...<br>msg_def = {<br>DEF_TLV_IE(BSSGP_PDUT_DL_UNITDATA, "DL-UNITDATA"),<br>...</p><p style="white-space: pre-wrap; word-wrap: break-word;">Just as an idea, not saying it needs to be done this way.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21544">change 21544</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21544"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7e4226463f3c935134b5c2c737696fbfd1dd5815 </div>
<div style="display:none"> Gerrit-Change-Number: 21544 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 07 Dec 2020 10:00:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>