<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21599">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: Assing different 8bit colors to built-in subsystems<br><br>The 16 ANSI colors we started to use for OpenBSC in 2008 were<br>sufficient for those few sub-systems that occurred in the BSC/NITB.<br><br>Over time, most sub-systems did not get colors anymore.  Let's<br>change that and assign more or less random colors from the 8bit<br>color palette.<br><br>Change-Id: Ia8c0f91a61fbca0441faf66b3f368f45f886187c<br>---<br>M src/logging.c<br>1 file changed, 22 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/21599/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/logging.c b/src/logging.c</span><br><span>index 0b4c1ff..efa108e 100644</span><br><span>--- a/src/logging.c</span><br><span>+++ b/src/logging.c</span><br><span>@@ -131,6 +131,7 @@</span><br><span>    { 0, NULL },</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* 256 color palette see https://en.wikipedia.org/wiki/ANSI_escape_code#8-bit */</span><br><span> #define INT2IDX(x)  (-1*(x)-1)</span><br><span> static const struct log_info_cat internal_cat[OSMO_NUM_DLIB] = {</span><br><span>       [INT2IDX(DLGLOBAL)] = { /* -1 becomes 0 */</span><br><span>@@ -138,110 +139,131 @@</span><br><span>                 .description = "Library-internal global log family",</span><br><span>               .loglevel = LOGL_NOTICE,</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+         .color = "\033[38;5;19m",</span><br><span>  },</span><br><span>   [INT2IDX(DLLAPD)] = {   /* -2 becomes 1 */</span><br><span>           .name = "DLLAPD",</span><br><span>          .description = "LAPD in libosmogsm",</span><br><span>               .loglevel = LOGL_NOTICE,</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+         .color = "\033[38;5;21m",</span><br><span>  },</span><br><span>   [INT2IDX(DLINP)] = {</span><br><span>                 .name = "DLINP",</span><br><span>           .description = "A-bis Intput Subsystem",</span><br><span>           .loglevel = LOGL_NOTICE,</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+         .color = "\033[38;5;23m",</span><br><span>  },</span><br><span>   [INT2IDX(DLMUX)] = {</span><br><span>                 .name = "DLMUX",</span><br><span>           .description = "A-bis B-Subchannel TRAU Frame Multiplex",</span><br><span>          .loglevel = LOGL_NOTICE,</span><br><span>             .enabled = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+         .color = "\033[38;5;25m",</span><br><span>  },</span><br><span>   [INT2IDX(DLMI)] = {</span><br><span>          .name = "DLMI",</span><br><span>            .description = "A-bis Input Driver for Signalling",</span><br><span>                .enabled = 0, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;27m",</span><br><span>  },</span><br><span>   [INT2IDX(DLMIB)] = {</span><br><span>                 .name = "DLMIB",</span><br><span>           .description = "A-bis Input Driver for B-Channels (voice)",</span><br><span>                .enabled = 0, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;29m",</span><br><span>  },</span><br><span>   [INT2IDX(DLSMS)] = {</span><br><span>                 .name = "DLSMS",</span><br><span>           .description = "Layer3 Short Message Service (SMS)",</span><br><span>               .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span>               .color = OSMO_LOGCOLOR_BRIGHTWHITE,</span><br><span style="color: hsl(120, 100%, 40%);">+           .color = "\033[38;5;31m",</span><br><span>  },</span><br><span>   [INT2IDX(DLCTRL)] = {</span><br><span>                .name = "DLCTRL",</span><br><span>          .description = "Control Interface",</span><br><span>                .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;33m",</span><br><span>  },</span><br><span>   [INT2IDX(DLGTP)] = {</span><br><span>                 .name = "DLGTP",</span><br><span>           .description = "GPRS GTP library",</span><br><span>                 .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;35m",</span><br><span>  },</span><br><span>   [INT2IDX(DLSTATS)] = {</span><br><span>               .name = "DLSTATS",</span><br><span>                 .description = "Statistics messages and logging",</span><br><span>          .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;37m",</span><br><span>  },</span><br><span>   [INT2IDX(DLGSUP)] = {</span><br><span>                .name = "DLGSUP",</span><br><span>          .description = "Generic Subscriber Update Protocol",</span><br><span>               .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;39m",</span><br><span>  },</span><br><span>   [INT2IDX(DLOAP)] = {</span><br><span>                 .name = "DLOAP",</span><br><span>           .description = "Osmocom Authentication Protocol",</span><br><span>          .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;41m",</span><br><span>  },</span><br><span>   [INT2IDX(DLSS7)] = {</span><br><span>                 .name = "DLSS7",</span><br><span>           .description = "libosmo-sigtran Signalling System 7",</span><br><span>              .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;43m",</span><br><span>  },</span><br><span>   [INT2IDX(DLSCCP)] = {</span><br><span>                .name = "DLSCCP",</span><br><span>          .description = "libosmo-sigtran SCCP Implementation",</span><br><span>              .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;45m",</span><br><span>  },</span><br><span>   [INT2IDX(DLSUA)] = {</span><br><span>                 .name = "DLSUA",</span><br><span>           .description = "libosmo-sigtran SCCP User Adaptation",</span><br><span>             .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;47m",</span><br><span>  },</span><br><span>   [INT2IDX(DLM3UA)] = {</span><br><span>                .name = "DLM3UA",</span><br><span>          .description = "libosmo-sigtran MTP3 User Adaptation",</span><br><span>             .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;49m",</span><br><span>  },</span><br><span>   [INT2IDX(DLMGCP)] = {</span><br><span>                .name = "DLMGCP",</span><br><span>          .description = "libosmo-mgcp Media Gateway Control Protocol",</span><br><span>              .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;51m",</span><br><span>  },</span><br><span>   [INT2IDX(DLJIBUF)] = {</span><br><span>               .name = "DLJIBUF",</span><br><span>                 .description = "libosmo-netif Jitter Buffer",</span><br><span>              .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;53m",</span><br><span>  },</span><br><span>   [INT2IDX(DLRSPRO)] = {</span><br><span>               .name = "DLRSPRO",</span><br><span>                 .description = "Remote SIM protocol",</span><br><span>              .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;55m",</span><br><span>  },</span><br><span>   [INT2IDX(DLNS)] = {</span><br><span>          .name = "DLNS",</span><br><span>            .description = "GPRS NS layer",</span><br><span>            .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;57m",</span><br><span>  },</span><br><span>   [INT2IDX(DLBSSGP)] = {</span><br><span>               .name = "DLBSSGP",</span><br><span>                 .description = "GPRS BSSGP layer",</span><br><span>                 .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                .color = "\033[38;5;59m",</span><br><span>  },</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21599">change 21599</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21599"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia8c0f91a61fbca0441faf66b3f368f45f886187c </div>
<div style="display:none"> Gerrit-Change-Number: 21599 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>