<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21442">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">power_control: lchan_ul_pf_ewma(): do not use lchan->meas.res_nr<br><br>This would allow to pass only two pointers:<br><br>  - 'struct bts_power_ctrl_params', and<br>  - 'struct lchan_power_ctrl_state',<br><br>and get rid of 'struct gsm_lchan' dependency.  The later is<br>exactly where all state variables are supposed to be kept.<br><br>Change-Id: Idfefca30f4944bc722b4e9d8f1685eb77670a9db<br>Related: SYS#4918<br>---<br>M src/common/power_control.c<br>M tests/power/ms_power_loop_test.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/power_control.c b/src/common/power_control.c</span><br><span>index 3328167..5dbf8ce 100644</span><br><span>--- a/src/common/power_control.c</span><br><span>+++ b/src/common/power_control.c</span><br><span>@@ -82,7 +82,7 @@</span><br><span>         int *Avg100 = &lchan->ms_power_ctrl.avg100_rxlev_dbm;</span><br><span> </span><br><span>     /* We don't have 'Avg[n - 1]' if this is the first run */</span><br><span style="color: hsl(0, 100%, 40%);">-   if (lchan->meas.res_nr == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (*Avg100 == 0) {</span><br><span>          *Avg100 = Pwr * EWMA_SCALE_FACTOR;</span><br><span>           return Pwr;</span><br><span>  }</span><br><span>diff --git a/tests/power/ms_power_loop_test.c b/tests/power/ms_power_loop_test.c</span><br><span>index 1abe532..147c725 100644</span><br><span>--- a/tests/power/ms_power_loop_test.c</span><br><span>+++ b/tests/power/ms_power_loop_test.c</span><br><span>@@ -191,7 +191,7 @@</span><br><span> </span><br><span>     g_bts->ul_power_ctrl.pf.ewma.alpha = 70; /* 30% smoothing */</span><br><span>      lchan->ms_power_ctrl.current = 15;</span><br><span style="color: hsl(0, 100%, 40%);">-   lchan->meas.res_nr = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+    lchan->ms_power_ctrl.avg100_rxlev_dbm = 0;</span><br><span> </span><br><span>    /* This is the first sample, the filter outputs it as-is */</span><br><span>  apply_power_test(lchan, -50, 0, 15);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21442">change 21442</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21442"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idfefca30f4944bc722b4e9d8f1685eb77670a9db </div>
<div style="display:none"> Gerrit-Change-Number: 21442 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>