<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21497">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nm_bts_sm_fsm: Fix peer_has_no_avstate_offline not applied for nanobts<br><br>The condition was set in st_op_disabled_notinstalled_on_enter():<br>"""<br>site_mgr->peer_has_no_avstate_offline = (bts->type == GSM_BTS_TYPE_NANOBTS);<br>"""<br><br>However, at startup of the FSM the oneneter func of the default initial<br>state is not called. In any case, if called it would be too early since<br>the type is not known yet (because its parsed later on at the VTY with<br>the "type" command, that's after the "bts X" node is called and the<br>bts_sm is allocated.<br>So we need to make sure to always enable it, also for nanobts.<br><br>Change-Id: Ic6049a44ae3fca1b8e968fe800c268f579e7cad4<br>---<br>M src/osmo-bsc/nm_bts_sm_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/21497/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/nm_bts_sm_fsm.c b/src/osmo-bsc/nm_bts_sm_fsm.c</span><br><span>index e5b5a3c..815eea6 100644</span><br><span>--- a/src/osmo-bsc/nm_bts_sm_fsm.c</span><br><span>+++ b/src/osmo-bsc/nm_bts_sm_fsm.c</span><br><span>@@ -78,8 +78,8 @@</span><br><span>                                          "have your .cfg with 'type nanobts'. Otherwise, you probably "</span><br><span>                                     "are using an old osmo-bts; automatically adjusting OML "</span><br><span>                                          "behavior to be backward-compatible.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                            site_mgr->peer_has_no_avstate_offline = true;</span><br><span>                     }</span><br><span style="color: hsl(120, 100%, 40%);">+                     site_mgr->peer_has_no_avstate_offline = true;</span><br><span>                     nm_bts_sm_fsm_state_chg(fi, NM_BTS_SM_ST_OP_ENABLED);</span><br><span>                        return;</span><br><span>              }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21497">change 21497</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21497"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic6049a44ae3fca1b8e968fe800c268f579e7cad4 </div>
<div style="display:none"> Gerrit-Change-Number: 21497 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>