<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21472">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_vty: Re-introduce a 'show ns' command<br><br>In I157467d6a74d6109bc23521c978c5aac6d29fe50 we introduced a split<br>between 'show ns entities' and 'show ns binds'.  However, there is<br>at least one test case in osmo-sgsn.git which depends on 'show ns'<br>working.  So let's re-add it as a backwards compatible, hidden command.<br><br>Change-Id: I7571c6d82f7a712803d09d165abb6c7cb5ae2e5c<br>---<br>M src/gb/gprs_ns2_vty.c<br>1 file changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index 97becf6..8b8a999 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -324,6 +324,17 @@</span><br><span>   }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Backwards compatibility, among other things for the TestVTYGbproxy which expects</span><br><span style="color: hsl(120, 100%, 40%);">+ * 'show ns' to output something about binds */</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_HIDDEN(show_ns, show_ns_cmd, "show ns",</span><br><span style="color: hsl(120, 100%, 40%);">+     SHOW_STR SHOW_NS_STR)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+      dump_ns_entities(vty, vty_nsi, false, false);</span><br><span style="color: hsl(120, 100%, 40%);">+ dump_ns_bind(vty, vty_nsi, false);</span><br><span style="color: hsl(120, 100%, 40%);">+    return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(show_ns_binds, show_ns_binds_cmd, "show ns binds [stats]",</span><br><span>     SHOW_STR SHOW_NS_STR</span><br><span>         "Display information about the NS protocol binds\n"</span><br><span>@@ -802,6 +813,7 @@</span><br><span>          return 0;</span><br><span>    vty_elements_installed = true;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    install_lib_element_ve(&show_ns_cmd);</span><br><span>    install_lib_element_ve(&show_ns_binds_cmd);</span><br><span>      install_lib_element_ve(&show_ns_entities_cmd);</span><br><span>   install_lib_element_ve(&show_ns_pers_cmd);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21472">change 21472</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21472"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7571c6d82f7a712803d09d165abb6c7cb5ae2e5c </div>
<div style="display:none"> Gerrit-Change-Number: 21472 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>